CSS styling for main, bread list, and detail pages #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was
linked to
issues
Feb 9, 2024
This was
linked to
issues
Feb 9, 2024
|
Not sure if we need this bit of code for the map on line 8 to possibly fix any map inconsistencies displaying |
|
Looks good! I really love your PR template - particularly the type-of designation at the beginning!! Also, really appreciate the images in the PR comment 🙌 |
rsteckline
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue/feature/bug description:
CSS styling with medium and large breakpoints with new images and overlays in sections.
Added some styling to the navbar and main as well for breakpoints.
Added a welcome message to prompt the user to click a country.
Added screenshots for small CSS issues that will be fixed on the C# second iteration.
I have been the only one to have issues displaying the map like extra space and a lined grid, and we're hoping that those are only local to my display but will correct as needed.
Also noticed that upload was slow, maybe because of the image file sizes; will adjust as needed.
Checklist before requesting a review
What’s next:
Forking a copy of this repo as this is our first iteration, connected to the rails BE. We will make a second iteration of the front end to incorporate more fleshed out description for each country and restructured JSON response for recipe structure. Future CSS styling to fix small responsive discrepancies with the new data on the detail page.