Skip to content

Commit 5e7e48a

Browse files
committed
MAX_OVERSHOOT_PID_AUTOTUNE in all variants
1 parent 3f3372e commit 5e7e48a

9 files changed

+8
-3
lines changed

Firmware/temperature.cpp

-3
Original file line numberDiff line numberDiff line change
@@ -387,9 +387,6 @@ void __attribute__((noinline)) PID_autotune(float temp, int extruder, int ncycle
387387
}
388388
}
389389
}
390-
#ifndef MAX_OVERSHOOT_PID_AUTOTUNE
391-
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
392-
#endif
393390
if(input > (temp + MAX_OVERSHOOT_PID_AUTOTUNE)) {
394391
SERIAL_PROTOCOLLNPGM("PID Autotune failed! Temperature too high");
395392
pid_tuning_finished = true;

Firmware/variants/MK25-RAMBo10a.h

+1
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@
189189
#define DEFAULT_Kd 73.76
190190
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
191191
// Define PID constants for extruder
192+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
192193
#define DEFAULT_Kp 16.13
193194
#define DEFAULT_Ki 1.1625
194195
#define DEFAULT_Kd 56.23

Firmware/variants/MK25-RAMBo13a.h

+1
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@
189189
#define DEFAULT_Kd 73.76
190190
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
191191
// Define PID constants for extruder
192+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
192193
#define DEFAULT_Kp 16.13
193194
#define DEFAULT_Ki 1.1625
194195
#define DEFAULT_Kd 56.23

Firmware/variants/MK25S-RAMBo10a.h

+1
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@
189189
#define DEFAULT_Kd 73.76
190190
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
191191
// Define PID constants for extruder
192+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
192193
#define DEFAULT_Kp 16.13
193194
#define DEFAULT_Ki 1.1625
194195
#define DEFAULT_Kd 56.23

Firmware/variants/MK25S-RAMBo13a.h

+1
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@
189189
#define DEFAULT_Kd 73.76
190190
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
191191
// Define PID constants for extruder
192+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
192193
#define DEFAULT_Kp 16.13
193194
#define DEFAULT_Ki 1.1625
194195
#define DEFAULT_Kd 56.23

Firmware/variants/MK3-E3DREVO.h

+1
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@
325325
#define DEFAULT_Kd 73.76
326326
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
327327
// Define PID constants for E3D REVO
328+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
328329
#define DEFAULT_Kp 25.00
329330
#define DEFAULT_Ki 4.8
330331
#define DEFAULT_Kd 32.6

Firmware/variants/MK3.h

+1
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@
325325
#define DEFAULT_Kd 73.76
326326
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
327327
// Define PID constants for extruder
328+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
328329
#define DEFAULT_Kp 16.13
329330
#define DEFAULT_Ki 1.1625
330331
#define DEFAULT_Kd 56.23

Firmware/variants/MK3S-E3DREVO.h

+1
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@
325325
#define DEFAULT_Kd 73.76
326326
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
327327
// Define PID constants for E3D REVO
328+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
328329
#define DEFAULT_Kp 25.00
329330
#define DEFAULT_Ki 4.8
330331
#define DEFAULT_Kd 32.6

Firmware/variants/MK3S.h

+1
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,7 @@
325325
#define DEFAULT_Kd 73.76
326326
#else //NOT E3D_PT100_EXTRUDER_WITH_AMP || E3D_PT100_EXTRUDER_NO_AMP
327327
// Define PID constants for extruder
328+
#define MAX_OVERSHOOT_PID_AUTOTUNE 20
328329
#define DEFAULT_Kp 16.13
329330
#define DEFAULT_Ki 1.1625
330331
#define DEFAULT_Kd 56.23

0 commit comments

Comments
 (0)