Fix 3D filters making 2D games crash (#5588)

Author: D8H

Extensions/3D/AmbientLight.ts

@@ -6,6 +6,9 @@ namespace gdjs {
         target: EffectsTarget,
         effectData: EffectData
       ): gdjs.PixiFiltersTools.Filter {
+        if (typeof THREE === 'undefined') {
+          return new gdjs.PixiFiltersTools.EmptyFilter();
+        }
         return new (class implements gdjs.PixiFiltersTools.Filter {
           light: THREE.AmbientLight;
           _isEnabled: boolean;

Extensions/3D/DirectionalLight.ts

@@ -6,6 +6,9 @@ namespace gdjs {
         target: EffectsTarget,
         effectData: EffectData
       ): gdjs.PixiFiltersTools.Filter {
+        if (typeof THREE === 'undefined') {
+          return new gdjs.PixiFiltersTools.EmptyFilter();
+        }
         return new (class implements gdjs.PixiFiltersTools.Filter {
           light: THREE.DirectionalLight;
           rotationObject: THREE.Group;

Extensions/3D/ExponentialFog.ts

@@ -6,6 +6,9 @@ namespace gdjs {
         target: EffectsTarget,
         effectData: EffectData
       ): gdjs.PixiFiltersTools.Filter {
+        if (typeof THREE === 'undefined') {
+          return new gdjs.PixiFiltersTools.EmptyFilter();
+        }
         return new (class implements gdjs.PixiFiltersTools.Filter {
           fog: THREE.FogExp2;
 

Extensions/3D/HemisphereLight.ts

@@ -6,6 +6,9 @@ namespace gdjs {
         target: EffectsTarget,
         effectData: EffectData
       ): gdjs.PixiFiltersTools.Filter {
+        if (typeof THREE === 'undefined') {
+          return new gdjs.PixiFiltersTools.EmptyFilter();
+        }
         return new (class implements gdjs.PixiFiltersTools.Filter {
           light: THREE.HemisphereLight;
           rotationObject: THREE.Group;

Extensions/3D/LinearFog.ts

@@ -6,6 +6,9 @@ namespace gdjs {
         target: EffectsTarget,
         effectData: EffectData
       ): gdjs.PixiFiltersTools.Filter {
+        if (typeof THREE === 'undefined') {
+          return new gdjs.PixiFiltersTools.EmptyFilter();
+        }
         return new (class implements gdjs.PixiFiltersTools.Filter {
           fog: THREE.Fog;
 

GDJS/Runtime/pixi-renderers/pixi-filters-tools.ts

@@ -227,5 +227,24 @@ namespace gdjs {
         );
       }
     }
+
+    export class EmptyFilter {
+      isEnabled(target: EffectsTarget): boolean {
+        return false;
+      }
+      setEnabled(target: EffectsTarget, enabled: boolean): boolean {
+        return false;
+      }
+      applyEffect(target: EffectsTarget): boolean {
+        return false;
+      }
+      removeEffect(target: EffectsTarget): boolean {
+        return false;
+      }
+      updatePreRender(target: gdjs.EffectsTarget): any {}
+      updateDoubleParameter(parameterName: string, value: number): void {}
+      updateStringParameter(parameterName: string, value: string): void {}
+      updateBooleanParameter(parameterName: string, value: boolean): void {}
+    }
   }
 }