Skip to content

Commit a2fb4d6

Browse files
committed
[#108] Use if-else in deciding validator routing
1 parent b011afc commit a2fb4d6

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

contracts/SignatureValidatorManager.sol

+3-7
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ contract SignatureValidatorManager is RegistryManager, ISafeProtocolFunctionHand
9898
* @param data Calldata containing the 4 bytes function selector, 32 bytes message hash and payload.
9999
* Layout of data:
100100
* 0x00 to 0x04 - 4 bytes function selector when this contract is set as a function handler in the SafeProtocolManager i.e. 0x1626ba7e
101-
* 0x04 to 0x24 - 32 bytes hash of the signed message
101+
* 0x04 to 0x24 - 32 bytes hash of the message used for signing
102102
* 0x24 to end - bytes containing signatures or signatureData either one of the below:
103103
* If first 4 bytes of signatureData are 0xb5c726cb i.e. bytes4(keccak256("Account712Signature(bytes32,bytes32,bytes)")); then it will be interpreted as follows:
104104
* payload = abi.encodeWithSelector(0xb5c726cb, abi.encode(domainSeparator, structHash, signatures)
@@ -135,14 +135,10 @@ contract SignatureValidatorManager is RegistryManager, ISafeProtocolFunctionHand
135135

136136
if (bytes4(data[0x64:0x68]) == SIGNATURE_VALIDATOR_SELECTOR) {
137137
returnData = abi.encode(validateWithSignatureValdiator(account, sender, messageHash, data[0x68:]));
138-
139-
if (signatureValidatorHooksAddress != address(0)) {
140-
ISafeProtocolSignatureValidatorHooks(signatureValidatorHooksAddress).postValidationHook(account, prevalidationData);
141-
}
142-
return returnData;
138+
} else {
139+
returnData = defaultValidator(account, messageHash, signatureData);
143140
}
144141

145-
returnData = defaultValidator(account, messageHash, signatureData);
146142
if (signatureValidatorHooksAddress != address(0)) {
147143
ISafeProtocolSignatureValidatorHooks(signatureValidatorHooksAddress).postValidationHook(account, prevalidationData);
148144
}

0 commit comments

Comments
 (0)