Merge pull request #15496 from szsam/patch-1

0xc0170 · web-flow · commit 7e16b0044e9e · 2024-05-03T19:07:01.000+02:00
ESP8266: Fix accessing uninitialized variable
diff --git a/connectivity/drivers/wifi/esp8266-driver/ESP8266/ESP8266.cpp b/connectivity/drivers/wifi/esp8266-driver/ESP8266/ESP8266.cpp
@@ -1190,7 +1190,7 @@ bool ESP8266::get_sntp_config(bool *enable, int *timezone, char *server0,
                                  &tmp, timezone, server0, server1, server2)
                 && _parser.recv("OK\n");
     _smutex.unlock();
-    *enable = tmp ? true : false;
+    *enable = (done && tmp) ? true : false;
     return done;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1190,7 +1190,7 @@ bool ESP8266::get_sntp_config(bool enable, int timezone, char *server0,`
`1190`	`1190`	`&tmp, timezone, server0, server1, server2)`
`1191`	`1191`	`&& _parser.recv("OK\n");`
`1192`	`1192`	`_smutex.unlock();`
`1193`		`- *enable = tmp ? true : false;`
	`1193`	`+ *enable = (done && tmp) ? true : false;`
`1194`	`1194`	`return done;`
`1195`	`1195`	`}`
`1196`	`1196`