remove tmp array

Author: AdamYuan

drw.c

@@ -242,20 +242,21 @@ drw_setscheme(Drw *drw, Clr *scm)
 }
 
 Picture
-drw_create_resized_picture(Drw *drw, char *src, unsigned int srcw, unsigned int srch, unsigned int dstw, unsigned int dsth, char *tmp) {
+drw_picture_create_resized(Drw *drw, char *src, unsigned int srcw, unsigned int srch, unsigned int dstw, unsigned int dsth) {
 	Pixmap pm;
 	Picture pic;
 	GC gc;
 
 	if (srcw <= (dstw << 1u) && srch <= (dsth << 1u)) {
-		pm = XCreatePixmap(drw->dpy, drw->root, srcw, srch, 32);
 		XImage img = {
 			srcw, srch, 0, ZPixmap, src,
 			ImageByteOrder(drw->dpy), BitmapUnit(drw->dpy), BitmapBitOrder(drw->dpy), 32,
 			32, 0, 32,
 			0, 0, 0
 		};
 		XInitImage(&img);
+
+		pm = XCreatePixmap(drw->dpy, drw->root, srcw, srch, 32);
 		gc = XCreateGC(drw->dpy, pm, 0, NULL);
 		XPutImage(drw->dpy, pm, gc, &img, 0, 0, 0, 0, srcw, srch);
 		XFreeGC(drw->dpy, gc);
@@ -279,19 +280,19 @@ drw_create_resized_picture(Drw *drw, char *src, unsigned int srcw, unsigned int
 		if (!scaled) return None;
 		imlib_context_set_image(scaled);
 		imlib_image_set_has_alpha(1);
-		memcpy(tmp, imlib_image_get_data_for_reading_only(), (dstw * dsth) << 2);
-		imlib_free_image_and_decache();
 
-		pm = XCreatePixmap(drw->dpy, drw->root, dstw, dsth, 32);
 		XImage img = {
-			dstw, dsth, 0, ZPixmap, tmp,
-			ImageByteOrder(drw->dpy), BitmapUnit(drw->dpy), BitmapBitOrder(drw->dpy), 32,
-			32, 0, 32,
-			0, 0, 0
+		    dstw, dsth, 0, ZPixmap, (char *)imlib_image_get_data_for_reading_only(),
+		    ImageByteOrder(drw->dpy), BitmapUnit(drw->dpy), BitmapBitOrder(drw->dpy), 32,
+		    32, 0, 32,
+		    0, 0, 0
 		};
 		XInitImage(&img);
+
+		pm = XCreatePixmap(drw->dpy, drw->root, dstw, dsth, 32);
 		gc = XCreateGC(drw->dpy, pm, 0, NULL);
 		XPutImage(drw->dpy, pm, gc, &img, 0, 0, 0, 0, dstw, dsth);
+		imlib_free_image_and_decache();
 		XFreeGC(drw->dpy, gc);
 
 		pic = XRenderCreatePicture(drw->dpy, pm, XRenderFindStandardFormat(drw->dpy, PictStandardARGB32), 0, NULL);

drw.h

@@ -50,7 +50,7 @@ void drw_cur_free(Drw *drw, Cur *cursor);
 void drw_setfontset(Drw *drw, Fnt *set);
 void drw_setscheme(Drw *drw, Clr *scm);
 
-Picture drw_create_resized_picture(Drw *drw, char *src, unsigned int src_w, unsigned int src_h, unsigned int dst_w, unsigned int dst_h, char *tmp);
+Picture drw_picture_create_resized(Drw *drw, char *src, unsigned int src_w, unsigned int src_h, unsigned int dst_w, unsigned int dst_h);
 
 /* Drawing functions */
 void drw_rect(Drw *drw, int x, int y, unsigned int w, unsigned int h, int filled, int invert);

dwm.c

@@ -933,8 +933,7 @@ geticonprop(Window win, unsigned int *picw, unsigned int *pich)
 	uint32_t i, *bstp32 = (uint32_t *)bstp;
 	for (sz = w * h, i = 0; i < sz; ++i) bstp32[i] = prealpha(bstp[i]);
 
-	static char tmp[ICONSIZE * ICONSIZE << 2];
-	Picture ret = drw_create_resized_picture(drw, (char *)bstp, w, h, icw, ich, tmp);
+	Picture ret = drw_picture_create_resized(drw, (char *)bstp, w, h, icw, ich);
 	XFree(p);
 
 	return ret;