Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Recipe data is not Populated (Imp) #102

Closed
3 tasks done
AlfiyaSiddique opened this issue Oct 6, 2024 · 9 comments
Closed
3 tasks done

BUG: Recipe data is not Populated (Imp) #102

AlfiyaSiddique opened this issue Oct 6, 2024 · 9 comments
Assignees
Labels
gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 2 GSSOC level 2 Contribution - 25 points

Comments

@AlfiyaSiddique
Copy link
Owner

Is there an existing issue raised for this?

  • I have searched the existing issues

Describe your issue

Due to some bug the recipe data is not populating please check this is asap and provide a solution

Steps to reproduce

Check Receipe page
Chec main meals page

What was the expected result?

The recipe card data should populate

Proposed solution

Please add your solution in the comment

Would you like to work on this issue?

None

Terms & Conditions

  • I agree to follow the Code of Conduct
  • I'm a GSSOC'24 Ext contributor
@github-actions github-actions bot added gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted labels Oct 6, 2024
@AlfiyaSiddique
Copy link
Owner Author

If anyone is interested in fixing this issue please comment

@AlfiyaSiddique
Copy link
Owner Author

This is an important bug need to be fixed asap

@AlfiyaSiddique AlfiyaSiddique added the level 2 GSSOC level 2 Contribution - 25 points label Oct 6, 2024
@AlfiyaSiddique
Copy link
Owner Author

image

@yours7himanshu
Copy link
Contributor

@AlfiyaSiddique I can fix this too

@AlfiyaSiddique
Copy link
Owner Author

@yours7himanshu assiging to you

@AlfiyaSiddique
Copy link
Owner Author

Fix this on priority

@yours7himanshu
Copy link
Contributor

Fix this on priority

Okay I wanna ask one thing..like previously I had worked repo and my PR has now merged...So I wanted to delete that forked repo and then fork it again for solving the new issue.It would be fine or it's a bad practice?

@yours7himanshu
Copy link
Contributor

Fix this on priority

didi jo apne backend server jo appne deploy kiya tha uska url dena pls asap

@yours7himanshu
Copy link
Contributor

Fix this on priority
@AlfiyaSiddique
I fixed it..The two problems i got and i changed that first---> In the backend section when u are using cors and on the allowedOrigin function u did'nt mention the frontend localhost url so anyone who is solving the issue using localhost will face a cors issue..

2nd one which was the main cause of the recipe.jsx and not causing the recipe to be populated is this - In your original code, you destructured the response data like this:

javascript

const { recipes, pagination } = response.data;

However, pagination is already a state variable in your component. By naming the destructured value from response.data as pagination, you were unintentionally creating a conflict between the local variable pagination (from the API response) and the state variable pagination.
Screenshot from 2024-10-07 12-46-59

@sadath2001
Copy link
Contributor

i think this is related to pagination.

@sadath2001
Copy link
Contributor

sadath2001 commented Oct 8, 2024

hi @AlfiyaSiddique , i have fixed this issue, can i raise a PR?

@AlfiyaSiddique
Copy link
Owner Author

Assigning to @sadath2001

@sadath2001
Copy link
Contributor

sadath2001 commented Oct 8, 2024

hi @AlfiyaSiddique , Raised a PR #129

@AlfiyaSiddique AlfiyaSiddique unpinned this issue Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext For GSSOC Extended Contribution. hacktoberfest-accepted level 2 GSSOC level 2 Contribution - 25 points
Projects
None yet
Development

No branches or pull requests

3 participants