Use target_* functions for dependencies

Author: Eliza Velasquez

CMakeLists.txt

@@ -12,12 +12,11 @@ macro(doption name help default def)
 endmacro()
 
 macro(make_simple_import name varname header library)
-  add_library(${name} UNKNOWN IMPORTED)
+  add_library(${name} INTERFACE)
   find_path(${varname}_INCLUDE ${header})
   find_library(${varname}_LIB NAMES ${library}-static ${library})
-  set_target_properties(${name} PROPERTIES
-    INTERFACE_INCLUDE_DIRECTORIES "${${varname}_INCLUDE}"
-    IMPORTED_LOCATION "${${varname}_LIB}")
+  target_include_directories(${name} INTERFACE "${${varname}_INCLUDE}")
+  target_link_libraries(${name} INTERFACE "${${varname}_LIB}")
 endmacro()
 
 option(BUILD_SHARED_LIBS "build shared library" ON)
@@ -38,12 +37,11 @@ doption(ENABLE_PHYSFS "enable PhysicsFS in playsound" OFF SUPPORT_PHYSFS)
 doption(STATIC_FLAC "FLAC should be linked as a static library" OFF FLAC__NO_DLL)
 
 # SDL2
-add_library(SDL2::SDL2 UNKNOWN IMPORTED)
+add_library(SDL2::SDL2 INTERFACE)
 find_path(SDL2_INCLUDE SDL.h PATH_SUFFIXES SDL2)
 find_library(SDL2_LIB NAMES SDL2 SDL2d)
-set_target_properties(SDL2::SDL2 PROPERTIES
-  INTERFACE_INCLUDE_DIRECTORIES "${SDL2_INCLUDE}"
-  IMPORTED_LOCATION "${SDL2_LIB}")
+target_include_directories(SDL2::SDL2 INTERFACE "${SDL2_INCLUDE}")
+target_link_libraries(SDL2::SDL2 INTERFACE "${SDL2_LIB}")
 if(WIN32)
   set(libs user32 gdi32 winmm imm32 ole32 oleaut32 version uuid advapi32 shell32)
 else()
@@ -52,21 +50,18 @@ else()
     list(APPEND libs rt)
   endif()
 endif()
-set_target_properties(SDL2::SDL2 PROPERTIES
-  INTERFACE_LINK_LIBRARIES "${libs}")
+target_link_libraries(SDL2::SDL2 INTERFACE "${libs}")
 unset(libs)
 
 if(WIN32)
-  add_library(SDL2::SDL2main UNKNOWN IMPORTED)
+  add_library(SDL2::SDL2main INTERFACE)
   set(libs)
   if(MINGW)
     list(APPEND libs mingw32)
   endif()
   find_library(SDL2MAIN_LIB NAMES SDL2main SDL2maind)
   list(APPEND libs "${SDL2MAIN_LIB}")
-  set_target_properties(SDL2::SDL2main PROPERTIES
-    IMPORTED_LOCATION "${SDL2MAIN_LIB}"
-    INTERFACE_LINK_LIBRARIES "${libs}")
+  target_link_libraries(SDL2::SDL2main INTERFACE "${libs}")
   unset(libs)
 else()
   add_library(SDL2::SDL2main INTERFACE IMPORTED)
@@ -95,12 +90,11 @@ endif()
 
 # ogg/flac
 if(ENABLE_FLAC)
-  add_library(ogg::FLAC UNKNOWN IMPORTED)
+  add_library(ogg::FLAC INTERFACE)
   find_path(FLAC_INCLUDE FLAC/stream_decoder.h)
   find_library(FLAC_LIB NAMES flac FLAC)
-  set_target_properties(ogg::FLAC PROPERTIES
-    INTERFACE_INCLUDE_DIRECTORIES "${FLAC_INCLUDE}"
-    IMPORTED_LOCATION "${FLAC_LIB}")
+  target_include_directories(ogg::FLAC INTERFACE "${FLAC_INCLUDE}")
+  target_link_libraries(ogg::FLAC INTERFACE "${FLAC_LIB}")
 endif()
 
 # ogg/speex