Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mocked region tests for pl.Int64 region_id #60

Open
3 tasks
Andre-Medina opened this issue Dec 29, 2024 · 0 comments
Open
3 tasks

Add mocked region tests for pl.Int64 region_id #60

Andre-Medina opened this issue Dec 29, 2024 · 0 comments
Labels
A~Region 🗺️ Area: Region data or features A~Tests 🧪 Creating and maintaining tests T-Feature 🚀 Type: New feature or request
Milestone
Demo Ready

Comments

@Andre-Medina
Copy link
Owner

Current situation

All mocked regions have a region_id column of pl.String. This causes unexpected errors with the SA1_2021 region which has a pl.Int64 region.

Expected solution

  • Add mocked region with pl.Int64 region_id.
  • Add mocked region with pl.Float64 region_id.
  • Make sure all pytests still work.
@Andre-Medina Andre-Medina added T-Feature 🚀 Type: New feature or request I-NEW ⚠️ Info: new issue to be looked into A~Tests 🧪 Creating and maintaining tests A~Region 🗺️ Area: Region data or features and removed I-NEW ⚠️ Info: new issue to be looked into labels Dec 29, 2024
@Andre-Medina Andre-Medina added this to the Demo Ready milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A~Region 🗺️ Area: Region data or features A~Tests 🧪 Creating and maintaining tests T-Feature 🚀 Type: New feature or request
Projects
None yet
Milestone
Demo Ready
Development

No branches or pull requests
1 participant
@Andre-Medina