Fix remaining properties issues

Author: carlesarnal

README.md

@@ -22,9 +22,9 @@ Starting with Apicurio Registry 3.0, we now produce a single artifact suitable f
 
 Which storage variant will be used is determined by the following configuration:
 
-|Option|Command argument|Env. variable|
-|---|---|---|
-|Registry Storage Variant|`-Dapicurio.storage.kind`|`REGISTRY_STORAGE_KIND`|
+|Option|Command argument| Env. variable           |
+|---|---|-------------------------|
+|Registry Storage Variant|`-Dapicurio.storage.kind`| `APICURIO_STORAGE_KIND` |
 
 For this property, there are three possible values:
 - *sql* - for the SQL storage variant.

app/src/main/java/io/apicurio/registry/metrics/health/readiness/PersistenceTimeoutReadinessCheck.java

@@ -54,7 +54,7 @@ public class PersistenceTimeoutReadinessCheck extends AbstractErrorCounterHealth
     /**
      * Set the operation duration in seconds, after which it's considered an error.
      */
-    @ConfigProperty(name = "apicurio.metrics.PersistenceTimeoutReadinessCheck.timeoutSec", defaultValue = "15")
+    @ConfigProperty(name = "apicurio.metrics.PersistenceTimeoutReadinessCheck.timeout.seconds", defaultValue = "15")
     @Info(category = "health", description = "Timeout of persistence readiness check", availableSince = "1.0.2.Final")
     Integer configTimeoutSec;
 

app/src/main/java/io/apicurio/registry/metrics/health/readiness/ResponseTimeoutReadinessCheck.java

@@ -63,7 +63,7 @@ public class ResponseTimeoutReadinessCheck extends AbstractErrorCounterHealthChe
      * Set the request duration in seconds, after which it's considered an error.
      * TODO This may be expected on some endpoints. Add a way to ignore those.
      */
-    @ConfigProperty(name = "apicurio.metrics.ResponseTimeoutReadinessCheck.timeoutSec", defaultValue = "10")
+    @ConfigProperty(name = "apicurio.metrics.ResponseTimeoutReadinessCheck.timeout.seconds", defaultValue = "10")
     @Info(category = "health", description = "Timeout of response readiness check", availableSince = "1.0.2.Final")
     Instance<Integer> configTimeoutSec;
 

app/src/main/java/io/apicurio/registry/storage/decorator/ReadOnlyRegistryStorageDecorator.java

@@ -47,7 +47,7 @@
 @ApplicationScoped
 public class ReadOnlyRegistryStorageDecorator extends RegistryStorageDecoratorReadOnlyBase implements RegistryStorageDecorator {
 
-    public static final String READ_ONLY_MODE_ENABLED_PROPERTY_NAME = "apicurio.storage.read-only";
+    public static final String READ_ONLY_MODE_ENABLED_PROPERTY_NAME = "apicurio.storage.read-only.enabled";
 
 
     @Dynamic(label = "Storage read-only mode", description = "When selected, " +

app/src/main/resources/application-prod.properties

@@ -9,11 +9,11 @@ apicurio.metrics.ResponseErrorLivenessCheck.statusResetWindowDuration.seconds=60
 apicurio.metrics.PersistenceTimeoutReadinessCheck.errorThreshold=5
 apicurio.metrics.PersistenceTimeoutReadinessCheck.counterResetWindowDuration.seconds=30
 apicurio.metrics.PersistenceTimeoutReadinessCheck.statusResetWindowDuration.seconds=60
-apicurio.metrics.PersistenceTimeoutReadinessCheck.timeoutSec=10
+apicurio.metrics.PersistenceTimeoutReadinessCheck.timeout.seconds=10
 apicurio.metrics.ResponseTimeoutReadinessCheck.errorThreshold=5
 apicurio.metrics.ResponseTimeoutReadinessCheck.counterResetWindowDuration.seconds=30
 apicurio.metrics.ResponseTimeoutReadinessCheck.statusResetWindowDuration.seconds=60
-apicurio.metrics.ResponseTimeoutReadinessCheck.timeoutSec=20
+apicurio.metrics.ResponseTimeoutReadinessCheck.timeout.seconds=20
 
 apicurio.liveness.errors.ignored=
 

app/src/main/resources/application.properties

@@ -119,7 +119,7 @@ apicurio.ccompat.max-subjects.dynamic.allow=${apicurio.config.dynamic.allow-all}
 apicurio.download.href.ttl.seconds.dynamic.allow=${apicurio.config.dynamic.allow-all}
 apicurio.ui.features.read-only.enabled.dynamic.allow=${apicurio.config.dynamic.allow-all}
 apicurio.rest.artifact.deletion.enabled.dynamic.allow=${apicurio.config.dynamic.allow-all}
-apicurio.storage.read-only.dynamic.allow=${apicurio.config.dynamic.allow-all}
+apicurio.storage.read-only.enabled.dynamic.allow=${apicurio.config.dynamic.allow-all}
 apicurio.authn.basic-client-credentials.enabled.dynamic.allow=${apicurio.config.dynamic.allow-all}
 
 # Error

app/src/test/java/io/apicurio/registry/storage/impl/readonly/ReadOnlyRegistryStorageTest.java

@@ -159,7 +159,7 @@ public class ReadOnlyRegistryStorageTest {
     void readOnlyTest() {
         notEnabled();
         var dto = new DynamicConfigPropertyDto();
-        dto.setName("apicurio.storage.read-only");
+        dto.setName("apicurio.storage.read-only.enabled");
         dto.setValue("true");
         storage.setConfigProperty(dto);
         enabled();

docs/modules/ROOT/partials/getting-started/ref-registry-all-configs.adoc

@@ -329,7 +329,7 @@ The following {registry} configuration options are available for each component
 |`300`
 |`1.0.2.Final`
 |Status reset window duration of persistence readiness check
-|`apicurio.metrics.PersistenceTimeoutReadinessCheck.timeoutSec`
+|`apicurio.metrics.PersistenceTimeoutReadinessCheck.timeout.seconds`
 |`integer`
 |`15`
 |`1.0.2.Final`
@@ -369,7 +369,7 @@ The following {registry} configuration options are available for each component
 |`300`
 |`1.0.2.Final`
 |Status reset window duration of response readiness check
-|`apicurio.metrics.ResponseTimeoutReadinessCheck.timeoutSec`
+|`apicurio.metrics.ResponseTimeoutReadinessCheck.timeout.seconds`
 |`instance<integer>`
 |`10`
 |`1.0.2.Final`
@@ -770,7 +770,7 @@ The following {registry} configuration options are available for each component
 |
 |`3.0.0.Final`
 |Application storage variant, for example, sql, kafkasql, or gitops
-|`apicurio.storage.read-only`
+|`apicurio.storage.read-only.enabled`
 |`boolean [dynamic]`
 |`false`
 |`2.5.0.Final`