Add simple checkstyle rules. (#169)

Author: alesj

.checkstyle/simple.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+        "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
+        "http://checkstyle.sourceforge.net/dtds/configuration_1_3.dtd">
+
+<module name="Checker">
+
+    <module name="TreeWalker">
+
+        <!-- code cleanup -->
+        <module name="UnusedImports">
+            <property name="processJavadoc" value="true"/>
+        </module>
+        <module name="RedundantImport"/>
+    </module>
+
+</module>
+

client/src/main/java/io/apicurio/registry/client/CachedRegistryService.java

@@ -16,6 +16,14 @@
 
 package io.apicurio.registry.client;
 
+import io.apicurio.registry.rest.beans.ArtifactMetaData;
+import io.apicurio.registry.rest.beans.EditableMetaData;
+import io.apicurio.registry.rest.beans.Rule;
+import io.apicurio.registry.rest.beans.VersionMetaData;
+import io.apicurio.registry.types.ArtifactType;
+import io.apicurio.registry.types.RuleType;
+import io.apicurio.registry.utils.IoUtil;
+
 import java.io.InputStream;
 import java.util.Collections;
 import java.util.List;
@@ -30,14 +38,6 @@
 import javax.ws.rs.Path;
 import javax.ws.rs.core.Response;
 
-import io.apicurio.registry.rest.beans.ArtifactMetaData;
-import io.apicurio.registry.rest.beans.EditableMetaData;
-import io.apicurio.registry.rest.beans.Rule;
-import io.apicurio.registry.rest.beans.VersionMetaData;
-import io.apicurio.registry.types.ArtifactType;
-import io.apicurio.registry.types.RuleType;
-import io.apicurio.registry.utils.IoUtil;
-
 /**
  * @author Ales Justin
  */

pom.xml

@@ -131,8 +131,11 @@
         <version.source.plugin>3.2.0</version.source.plugin>
         <version.surefire.plugin>2.22.2</version.surefire.plugin>
         <version.jar.plugin>3.2.0</version.jar.plugin>
+		<version.checkstyle.plugin>3.1.0</version.checkstyle.plugin>
         <version.properties.plugin>1.0.0</version.properties.plugin>
         <version.dependency.plugin>3.1.1</version.dependency.plugin>
+		<!-- Plugin Deps -->
+		<version.puppycrawl>8.26</version.puppycrawl>
         <!-- Proto -->
         <proto-plugin.version>0.6.1</proto-plugin.version>
         <os-maven-plugin.version>1.6.2</os-maven-plugin.version>
@@ -316,6 +319,11 @@
 					<artifactId>maven-jar-plugin</artifactId>
 					<version>${version.jar.plugin}</version>
 				</plugin>
+				<plugin>
+					<groupId>org.apache.maven.plugins</groupId>
+					<artifactId>maven-checkstyle-plugin</artifactId>
+					<version>${version.checkstyle.plugin}</version>
+				</plugin>
 				<plugin>
 					<groupId>org.jboss.jandex</groupId>
 					<artifactId>jandex-maven-plugin</artifactId>
@@ -407,6 +415,39 @@
 					<failOnWarnings>false</failOnWarnings>
 				</configuration>
 			</plugin>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-checkstyle-plugin</artifactId>
+				<dependencies>
+					<dependency>
+						<groupId>com.puppycrawl.tools</groupId>
+						<artifactId>checkstyle</artifactId>
+						<version>${version.puppycrawl}</version>
+					</dependency>
+				</dependencies>
+				<executions>
+					<execution>
+						<id>validate</id>
+						<phase>validate</phase>
+						<configuration>
+							<configLocation>.checkstyle/simple.xml
+							</configLocation>
+							<headerLocation>.checkstyle/java.header
+							</headerLocation>
+							<suppressionsLocation>.checkstyle/suppressions.xml
+							</suppressionsLocation>
+							<includeTestSourceDirectory>true
+							</includeTestSourceDirectory>
+							<encoding>UTF-8</encoding>
+							<consoleOutput>true</consoleOutput>
+							<failsOnError>true</failsOnError>
+						</configuration>
+						<goals>
+							<goal>check</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
 		</plugins>
 	</build>
 

tests/pom.xml

@@ -22,7 +22,6 @@
         <vertx.version>3.8.4</vertx.version>
         <scala.version>2.12.10</scala.version>
         <maven.dependency.version>3.1.1</maven.dependency.version>
-        <maven.checkstyle.version>3.0.0</maven.checkstyle.version>
         <log4j.version>1.7.28</log4j.version>
         <hamcrest.version>2.2</hamcrest.version>
     </properties>
@@ -184,12 +183,11 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>${maven.checkstyle.version}</version>
                 <dependencies>
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.18</version>
+                        <version>${version.puppycrawl}</version>
                     </dependency>
                 </dependencies>
                 <executions>

utils/serde/src/main/java/io/apicurio/registry/utils/serde/AvroKafkaDeserializer.java

@@ -16,24 +16,22 @@
 
 package io.apicurio.registry.utils.serde;
 
+import io.apicurio.registry.client.RegistryService;
+import io.apicurio.registry.utils.serde.avro.AvroDatumProvider;
+import io.apicurio.registry.utils.serde.avro.AvroSchemaUtils;
+import io.apicurio.registry.utils.serde.avro.DefaultAvroDatumProvider;
+import org.apache.avro.Schema;
+import org.apache.avro.io.DatumReader;
+import org.apache.avro.io.DecoderFactory;
+
 import java.io.IOException;
 import java.io.UncheckedIOException;
 import java.nio.ByteBuffer;
 import java.util.Map;
 import java.util.Objects;
 import java.util.function.Consumer;
-
 import javax.ws.rs.core.Response;
 
-import org.apache.avro.Schema;
-import org.apache.avro.io.DatumReader;
-import org.apache.avro.io.DecoderFactory;
-
-import io.apicurio.registry.client.RegistryService;
-import io.apicurio.registry.utils.serde.avro.AvroDatumProvider;
-import io.apicurio.registry.utils.serde.avro.AvroSchemaUtils;
-import io.apicurio.registry.utils.serde.avro.DefaultAvroDatumProvider;
-
 /**
  * @author Ales Justin
  */

utils/serde/src/main/java/io/apicurio/registry/utils/serde/strategy/TopicRecordIdStrategy.java

@@ -17,7 +17,6 @@
 package io.apicurio.registry.utils.serde.strategy;
 
 import org.apache.avro.Schema;
-import org.apache.kafka.common.errors.SerializationException;
 
 /**
  * @author Ales Justin