Skip to content

Commit b5d571f

Browse files
authoredFeb 7, 2024
[REST API v3] Merge labels and properties into "labels" (#4304)
* Initial attempt to remove labels and then rename properties to labels. * Remove old v2 "labels" and "properties" and replace with new v3 "labels" * Update the UI to merge labels and properties * Fix broken UI tests * Try to improve robustness of UI test * Added test for legacy v2 API label/property support * Update the default REST API endpoint in the UI config
1 parent 589bf9c commit b5d571f

File tree

85 files changed

+1370
-1809
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+1370
-1809
lines changed
 

‎.github/workflows/integration-tests.yaml

+6-1
Original file line numberDiff line numberDiff line change
@@ -259,11 +259,16 @@ jobs:
259259
curl -s http://localhost:8080/apis/registry/v3/system/info
260260
echo "--"
261261
echo ""
262-
echo "UI Config Info:"
262+
echo "UI Config Info (Local):"
263263
echo "--"
264264
curl -s http://localhost:8888/config.js
265265
echo "--"
266266
echo ""
267+
echo "UI Config Info (Remote):"
268+
echo "--"
269+
curl -s http://localhost:8080/apis/registry/v3/system/uiConfig
270+
echo "--"
271+
echo ""
267272
echo "UI Version Info:"
268273
curl -s http://localhost:8888/version.js
269274
echo "--"

‎app/src/main/java/io/apicurio/registry/cncf/schemaregistry/impl/CNCFApiUtil.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public static SchemaGroup dtoToSchemaGroup(GroupMetaDataDto dto) {
1616
}
1717
group.setCreatedtimeutc(new Date(dto.getCreatedOn()));
1818
group.setUpdatedtimeutc(new Date(dto.getModifiedOn()));
19-
group.setGroupProperties(dto.getProperties());
19+
group.setGroupProperties(dto.getLabels());
2020
return group;
2121
}
2222

0 commit comments

Comments
 (0)