Skip to content

Commit 057729c

Browse files
ArekBalysNordicArekBalysNordic
committed
Revert "[nrf noup] Use "continue-on-error" for examples in CI"
This reverts commit ec9212b.
1 parent 2a2c460 commit 057729c

File tree

1 file changed

+0
-39
lines changed

1 file changed

+0
-39
lines changed

‎.github/workflows/examples-nrfconnect.yaml

-39
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ jobs:
6969

7070
- name: Check nRF Connect SDK revision.
7171
run: scripts/run_in_build_env.sh "python3 scripts/setup/nrfconnect/update_ncs.py --check"
72-
continue-on-error: true
7372
- name: Run unit tests of factory data generation script
7473
run: |
7574
scripts/run_in_build_env.sh 'pip3 install -r scripts/setup/requirements.nrfconnect.txt'
@@ -84,8 +83,6 @@ jobs:
8483
/tmp/bloat_reports/
8584
- name: Build example nRF Connect SDK Lighting App on nRF52840 Dongle
8685
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
87-
continue-on-error: true
88-
timeout-minutes: 15
8986
run: |
9087
scripts/examples/nrfconnect_example.sh lighting-app nrf52840dongle_nrf52840 -DCONF_FILE=prj_no_dfu.conf -DCONFIG_CHIP_ROTATING_DEVICE_ID=y
9188
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -94,8 +91,6 @@ jobs:
9491
/tmp/bloat_reports/
9592
- name: Build example nRF Connect SDK Lighting App on nRF52840 DK with RPC
9693
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
97-
continue-on-error: true
98-
timeout-minutes: 20
9994
run: |
10095
scripts/examples/nrfconnect_example.sh lighting-app nrf52840dk_nrf52840 -DOVERLAY_CONFIG=rpc.overlay
10196
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -104,8 +99,6 @@ jobs:
10499
/tmp/bloat_reports/
105100
- name: Build example nRF Connect SDK Light Switch App on nRF52840 DK
106101
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
107-
continue-on-error: true
108-
timeout-minutes: 15
109102
run: |
110103
scripts/examples/nrfconnect_example.sh light-switch-app nrf52840dk_nrf52840
111104
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -114,28 +107,14 @@ jobs:
114107
/tmp/bloat_reports/
115108
- name: Build example nRF Connect SDK Shell on nRF52840 DK
116109
if: github.event_name == 'push' || steps.changed_paths.outputs.shell == 'true'
117-
continue-on-error: true
118-
timeout-minutes: 15
119110
run: |
120111
scripts/examples/nrfconnect_example.sh shell nrf52840dk_nrf52840
121112
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
122113
nrfconnect nrf52840dk_nrf52840 shell \
123114
examples/shell/nrfconnect/build/zephyr/zephyr.elf \
124115
/tmp/bloat_reports/
125-
- name: Build example nRF Connect SDK Pigweed on nRF52840 DK
126-
if: github.event_name == 'push' || steps.changed_paths.outputs.pigweed-app == 'true'
127-
continue-on-error: true
128-
timeout-minutes: 15
129-
run: |
130-
scripts/examples/nrfconnect_example.sh pigweed-app nrf52840dk_nrf52840
131-
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
132-
nrfconnect nrf52840dk_nrf52840 pigweed-app \
133-
examples/pigweed-app/nrfconnect/build/zephyr/zephyr.elf \
134-
/tmp/bloat_reports/
135116
- name: Build example nRF Connect SDK Pump App on nRF52840 DK
136117
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
137-
continue-on-error: true
138-
timeout-minutes: 15
139118
run: |
140119
scripts/examples/nrfconnect_example.sh pump-app nrf52840dk_nrf52840
141120
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -144,26 +123,20 @@ jobs:
144123
/tmp/bloat_reports/
145124
- name: Build example nRF Connect SDK Pump Controller App on nRF52840 DK
146125
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
147-
continue-on-error: true
148-
timeout-minutes: 15
149126
run: |
150127
scripts/examples/nrfconnect_example.sh pump-controller-app nrf52840dk_nrf52840
151128
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
152129
nrfconnect nrf52840dk_nrf52840 pump-controller-app \
153130
examples/pump-controller-app/nrfconnect/build/zephyr/zephyr.elf \
154131
/tmp/bloat_reports/
155132
- name: Build example nRF Connect SDK All Clusters App on nRF52840 DK
156-
continue-on-error: true
157-
timeout-minutes: 20
158133
run: |
159134
scripts/examples/nrfconnect_example.sh all-clusters-app nrf52840dk_nrf52840
160135
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
161136
nrfconnect nrf52840dk_nrf52840 all-clusters-app \
162137
examples/all-clusters-app/nrfconnect/build/zephyr/zephyr.elf \
163138
/tmp/bloat_reports/
164139
- name: Build example nRF Connect SDK All Clusters Minimal App on nRF52840 DK
165-
continue-on-error: true
166-
timeout-minutes: 20
167140
run: |
168141
scripts/examples/nrfconnect_example.sh all-clusters-minimal-app nrf52840dk_nrf52840 -DCONF_FILE=prj_dfu.conf
169142
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -172,8 +145,6 @@ jobs:
172145
/tmp/bloat_reports/
173146
- name: Build example nRF Connect SDK Lock App on nRF5340 DK
174147
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
175-
continue-on-error: true
176-
timeout-minutes: 15
177148
run: |
178149
scripts/examples/nrfconnect_example.sh lock-app nrf5340dk_nrf5340_cpuapp
179150
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -182,8 +153,6 @@ jobs:
182153
/tmp/bloat_reports/
183154
- name: Build example nRF Connect SDK Lighting App on nRF5340 DK
184155
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
185-
continue-on-error: true
186-
timeout-minutes: 15
187156
run: |
188157
scripts/examples/nrfconnect_example.sh lighting-app nrf5340dk_nrf5340_cpuapp
189158
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -192,8 +161,6 @@ jobs:
192161
/tmp/bloat_reports/
193162
- name: Build example nRF Connect SDK Lock App on nRF7002 PDK
194163
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
195-
continue-on-error: true
196-
timeout-minutes: 20
197164
run: |
198165
scripts/examples/nrfconnect_example.sh lock-app nrf7002dk_nrf5340_cpuapp
199166
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -202,8 +169,6 @@ jobs:
202169
/tmp/bloat_reports/
203170
- name: Build example nRF Connect SDK Light Switch App on nRF7002 PDK
204171
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
205-
continue-on-error: true
206-
timeout-minutes: 20
207172
run: |
208173
scripts/examples/nrfconnect_example.sh light-switch-app nrf7002dk_nrf5340_cpuapp
209174
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
@@ -212,17 +177,13 @@ jobs:
212177
/tmp/bloat_reports/
213178
- name: Build example nRF Connect SDK Lighting App on nRF7002 PDK
214179
if: github.event_name == 'push' || steps.changed_paths.outputs.nrfconnect == 'true'
215-
continue-on-error: true
216-
timeout-minutes: 20
217180
run: |
218181
scripts/examples/nrfconnect_example.sh lighting-app nrf7002dk_nrf5340_cpuapp
219182
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \
220183
nrfconnect nrf7002dk_nrf5340_cpuapp lighting-app \
221184
examples/light-switch-app/nrfconnect/build/zephyr/zephyr.elf \
222185
/tmp/bloat_reports/
223186
- name: Build example nRF Connect SDK All Clusters App on nRF7002 PDK
224-
continue-on-error: true
225-
timeout-minutes: 20
226187
run: |
227188
scripts/examples/nrfconnect_example.sh all-clusters-app nrf7002dk_nrf5340_cpuapp -DCONF_FILE=prj_release.conf
228189
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py \

0 commit comments

Comments
 (0)