Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slash - Infos console warning #648

Open
sofianeoudina opened this issue Dec 5, 2024 · 1 comment · May be fixed by #746
Open

Slash - Infos console warning #648

sofianeoudina opened this issue Dec 5, 2024 · 1 comment · May be fixed by #746
Labels
agent-slash Component for the agent theme bug Something isn't working

Comments

@sofianeoudina
Copy link

A warning appears when using Infos component when id is not provided (id can be undefined)

image
image
@MartinWeb
Copy link
Contributor

Hard to say how to correct it, we tried some things with @JLou
We cannot rely on the definition or word property because they are ReactNode.

One solution would be to make the id required but that would make a breaking change so we might let it like that for v1 and change in next version.

pplancq added a commit that referenced this issue Jan 14, 2025
@pplancq
fix(slash): fix console warning when using Infos component when id is…
d5f9658 
… not provided

Ref: #648
@pplancq pplancq linked a pull request Jan 14, 2025 that will close this issue
Open
pplancq added a commit that referenced this issue Jan 14, 2025
@pplancq
fix(slash): fix console warning when using Infos component when id is…
0c4cb1f 
… not provided

Ref: #648
@pplancq pplancq added bug Something isn't working agent-slash Component for the agent theme labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-slash Component for the agent theme bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@MartinWeb @sofianeoudina @pplancq