Removing Version() check in tests. (#130)

It is a reasonable expectation from our customers that `go test` should
execute without failure on master from their machines. At the moment,
there is a by design failure because the version matches the most
recently published tag.

Eventually, we should enforce this again, but not until we can do so
only for our own release pipeline. To ensure folks don't get snared on
this, we'll delete the offending test here.

Author: marstr

autorest/version.go

@@ -2,22 +2,28 @@ package autorest
 
 import (
 	"fmt"
+	"strings"
+	"sync"
 )
 
 const (
-	major        = "7"
-	minor        = "3"
-	patch        = "0"
-	tag          = ""
-	semVerFormat = "%s.%s.%s%s"
+	major = 7
+	minor = 3
+	patch = 1
+	tag   = ""
 )
 
+var versionLock sync.Once
 var version string
 
 // Version returns the semantic version (see http://semver.org).
 func Version() string {
-	if version == "" {
-		version = fmt.Sprintf(semVerFormat, major, minor, patch, tag)
-	}
+	versionLock.Do(func() {
+		version = fmt.Sprintf("v%d.%d.%d", major, minor, patch)
+
+		if trimmed := strings.TrimPrefix(tag, "-"); trimmed != "" {
+			version = fmt.Sprintf("%s-%s", version, trimmed)
+		}
+	})
 	return version
 }