Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument Improvement for Python Scripts #583

Open
MikeZappa87 opened this issue Mar 31, 2025 · 0 comments
Open

Argument Improvement for Python Scripts #583

MikeZappa87 opened this issue Mar 31, 2025 · 0 comments

Comments

@MikeZappa87
Copy link
Contributor

MikeZappa87 commented Mar 31, 2025

I noticed in this file

PYTHONPATH=$PYTHONPATH:$(pwd) python3 $PYTHON_SCRIPT_FILE configure \

We are not using named arguments such as --{somearg}={some value}. The current approach will eventually become very tough to maintain. The slo.py (

parser = argparse.ArgumentParser(description="SLO Kubernetes resources.")
) is already using named arguments as well. Is it possible to update the current approach to make use of the named arguments for maintainability? It's much easier for someone to trace the code if we use named arguments. Positional is good with 1 or 2 arguments, not more than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant