-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native ARM64 builds and release updates #179
Open
philnach
wants to merge
34
commits into
AzureCosmosDB:main
Choose a base branch
from
philnach:armBuilds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request updates the build and release workflows as well as the documentation to support native ARM64 builds. Key changes include:
- Updating build configurations and workflows with a matrix strategy to build self-contained executables for multiple platforms and architectures.
- Refactoring build command output paths from using platform-short to the runtime input.
- Enhancing documentation to cover new platforms and provide guidance on using RBAC with Azure CLI.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
README.md | Updated installation instructions for added platforms and ARM64; added RBAC authentication guidance. |
.github/workflows/release.yml | Introduced a matrix strategy for package builds and updated the release job to handle ARM64 packages. |
.github/workflows/internal-test-build.yml | Added a matrix build strategy for self-contained executables across multiple platforms and architectures. |
.github/actions/build-with-plugins/action.yml | Refactored dotnet publish commands to use the runtime input for determining output paths. |
Good catch Copilot! Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the build and release workflows, as well as improvements to the documentation. The main changes involve refactoring the build configurations to use a matrix strategy, updating the output paths, and enhancing the release process to support multiple platforms and architectures. New ARM64 builds have been added to the release packages.
closes #178
Workflow and Build Configuration Updates:
.github/actions/build-with-plugins/action.yml
: Updated thedotnet publish
commands to use${{ inputs.runtime }}
instead of${{ inputs.platform-short }}
for the output paths. This change ensures consistency in the output directory structure. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11].github/workflows/internal-test-build.yml
: Introduced a matrix strategy to build self-contained executables for different platforms and architectures, streamlining the build process and reducing redundancy..github/workflows/release.yml
: Added a matrix strategy for building packages and updated the release job to handle multiple platforms and architectures. This change simplifies the release process and ensures all necessary packages are created and uploaded.Linux release packages have been switched to tarball's vs. zip as tar is a more common package available on Linux distros.
Documentation Updates:
README.md
: Updated installation instructions to include new platforms and architectures (win-arm64, mac-arm64, linux-arm64) and added guidance for using RBAC and authentication with Azure CLI. [1] [2]How verified: