Would contributions to fix clippy lints for the project be appreciated? #3017
-
|
I'm working on improving my knowledge in rust, and figured that one type of task I could tackle while doing so would be to go through various projects and do some clean-up of linter warnings and other such "chore-like" issues. @BurntSushi: would this be something you'd appreciate, or should I hold back on this in favour of other ways to contribute? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
Such has been done several times before: https://github.com/search?q=repo%3ABurntSushi%2Fripgrep+clippy&type=pullrequests Generally, no, I don't invite these sorts of PRs. I disagree with a lot of the lints Clippy uses by default, so it kind of winds up being a huge time sink to go through each fix. In theory, I do want to have Clippy running, but only on the set of lints I care about. The problem is that I have a lot of repos and it would take non-trivial time to go and set it up everywhere. If you find real bugs, sure, PRs are welcome for that. But if it's just shifting around style and what not, I'm not as enthused about that. |
Beta Was this translation helpful? Give feedback.
-
|
Makes sense. I'll focus my attention towards other types of issues instead then 👍 |
Beta Was this translation helpful? Give feedback.
Such has been done several times before: https://github.com/search?q=repo%3ABurntSushi%2Fripgrep+clippy&type=pullrequests
Generally, no, I don't invite these sorts of PRs. I disagree with a lot of the lints Clippy uses by default, so it kind of winds up being a huge time sink to go through each fix.
In theory, I do want to have Clippy running, but only on the set of lints I care about. The problem is that I have a lot of repos and it would take non-trivial time to go and set it up everywhere.
If you find real bugs, sure, PRs are welcome for that. But if it's just shifting around style and what not, I'm not as enthused about that.