Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: name of release artifacts should be tag-based #1059

Open
danielphan2003 opened this issue Dec 16, 2021 · 0 comments
Open

Feature request: name of release artifacts should be tag-based #1059

danielphan2003 opened this issue Dec 16, 2021 · 0 comments
Labels
T-enhancement Type: Enhancement

Comments

@danielphan2003
Copy link

Is your feature request related to a problem? Please describe.
I'm using https://github.com/berberman/nvfetcher to fetch release artifacts from sodium-fabric, and having build number appended to file name makes it harder to get an exact url of each release.

Describe the solution you'd like
Change artifact name for each release (and possibly CI build) to sodium-fabric-mc${Minecraft version}-${Sodium version}.jar.

Describe alternatives you've considered
Using regex to match the version I'm looking for, but that would be problematic if sodium-fabric decided to include more files in each release.

Additional context
See https://github.com/CaffeineMC/sodium-fabric/releases/tag/mc1.17.1-0.3.3

@danielphan2003 danielphan2003 added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels Dec 16, 2021
danielphan2003 added a commit to danielphan2003/fog that referenced this issue Dec 16, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
 - use bud cache when possible
 - minecraft-*: each package based on major minecraft-server versions
 - minecraft-starlight-{fabric,forge}: init
 - minecraft-sodium: commented out for further fixes CaffeineMC/sodium#1059
 - minecraft-fast-furnace: out of date, not found elsewhere
@danielphan2003 danielphan2003 changed the title FR: release artifacts should be tag-based only Feature request: name of release artifacts should be tag-based Dec 18, 2021
@pajicadvance pajicadvance removed the S-needs-triage Status: Needs triage label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants