Removed LowCardinality(UInt64) tests that caused allow_suspicious_low_cardinality_types related error (#1206)

jkaflik · web-flow · commit 34af93215b57 · 2024-02-28T11:46:28.000+01:00
diff --git a/examples/std/map.go b/examples/std/map.go
@@ -19,6 +19,7 @@ package std
 
 import (
 	"fmt"
+
 	"github.com/ClickHouse/clickhouse-go/v2"
 )
 
@@ -33,7 +34,7 @@ func MapInsertRead() error {
 			, Col2 Map(String, UInt64)
 			, Col3 Map(String, UInt64)
 			, Col4 Array(Map(String, String))
-			, Col5 Map(LowCardinality(String), LowCardinality(UInt64))
+			, Col5 Map(LowCardinality(String), LowCardinality(String))
 		) Engine Memory
 		`
 	conn.Exec("DROP TABLE example")
@@ -65,9 +66,9 @@ func MapInsertRead() error {
 			{"A": "B"},
 			{"C": "D"},
 		}
-		col5Data = map[string]uint64{
-			"key_col_5_1": 100,
-			"key_col_5_2": 200,
+		col5Data = map[string]string{
+			"key_col_5_1": "100",
+			"key_col_5_2": "200",
 		}
 	)
 	if _, err := batch.Exec(col1Data, col2Data, col3Data, col4Data, col5Data); err != nil {
@@ -81,7 +82,7 @@ func MapInsertRead() error {
 		col2 map[string]uint64
 		col3 map[string]uint64
 		col4 []map[string]string
-		col5 map[string]uint64
+		col5 map[string]string
 	)
 	if err := conn.QueryRow("SELECT * FROM example").Scan(&col1, &col2, &col3, &col4, &col5); err != nil {
 		return err
diff --git a/tests/issues/692_test.go b/tests/issues/692_test.go
@@ -48,7 +48,7 @@ func TestIssue692(t *testing.T) {
 			, Col2 Map(String, UInt64)
 			, Col3 Map(String, UInt64)
 			, Col4 Array(Map(String, String))
-			, Col5 Map(LowCardinality(String), LowCardinality(UInt64))
+			, Col5 Map(LowCardinality(String), LowCardinality(String))
 			, Col6 Map(String, Map(String, Int64))
 		) Engine MergeTree() ORDER BY tuple()
 		`
@@ -77,9 +77,9 @@ func TestIssue692(t *testing.T) {
 			{"A": "B"},
 			{"C": "D"},
 		}
-		col5Data = map[string]uint64{
-			"key_col_5_1": 100,
-			"key_col_5_2": 200,
+		col5Data = map[string]string{
+			"key_col_5_1": "100",
+			"key_col_5_2": "200",
 		}
 		col6Data = map[string]map[string]int64{}
 	)
@@ -91,7 +91,7 @@ func TestIssue692(t *testing.T) {
 		col2 map[string]uint64
 		col3 map[string]uint64
 		col4 []map[string]string
-		col5 map[string]uint64
+		col5 map[string]string
 		col6 map[string]map[string]int64
 	)
 	require.NoError(t, conn.QueryRow("SELECT Col1, Col2, Col3, Col4, Col5, Col6 FROM test_map").Scan(&col1, &col2, &col3, &col4, &col5, &col6))
diff --git a/tests/map_test.go b/tests/map_test.go
@@ -48,7 +48,7 @@ func TestMap(t *testing.T) {
 			, Col2 Map(String, UInt64)
 			, Col3 Map(String, UInt64)
 			, Col4 Array(Map(String, String))
-			, Col5 Map(LowCardinality(String), LowCardinality(UInt64))
+			, Col5 Map(LowCardinality(String), LowCardinality(String))
 			, Col6 Map(String, Map(String,UInt64))
 		) Engine MergeTree() ORDER BY tuple()
 		`
@@ -72,9 +72,9 @@ func TestMap(t *testing.T) {
 			map[string]string{"A": "B"},
 			map[string]string{"C": "D"},
 		}
-		col5Data = map[string]uint64{
-			"key_col_5_1": 100,
-			"key_col_5_2": 200,
+		col5Data = map[string]string{
+			"key_col_5_1": "100",
+			"key_col_5_2": "200",
 		}
 		col6Data = map[string]map[string]uint64{
 			"key_col_6_1": {
@@ -95,7 +95,7 @@ func TestMap(t *testing.T) {
 		col2 map[string]uint64
 		col3 map[string]uint64
 		col4 []map[string]string
-		col5 map[string]uint64
+		col5 map[string]string
 		col6 map[string]map[string]uint64
 	)
 	require.NoError(t, conn.QueryRow(ctx, "SELECT * FROM test_map").Scan(&col1, &col2, &col3, &col4, &col5, &col6))
diff --git a/tests/std/map_test.go b/tests/std/map_test.go
@@ -50,7 +50,7 @@ func TestStdMap(t *testing.T) {
 			, Col2 Map(String, UInt64)
 			, Col3 Map(String, UInt64)
 			, Col4 Array(Map(String, String))
-			, Col5 Map(LowCardinality(String), LowCardinality(UInt64))
+			, Col5 Map(LowCardinality(String), LowCardinality(String))
 		) Engine MergeTree() ORDER BY tuple()
 		`
 			defer func() {
@@ -76,9 +76,9 @@ func TestStdMap(t *testing.T) {
 					map[string]string{"A": "B"},
 					map[string]string{"C": "D"},
 				}
-				col5Data = map[string]uint64{
-					"key_col_5_1": 100,
-					"key_col_5_2": 200,
+				col5Data = map[string]string{
+					"key_col_5_1": "100",
+					"key_col_5_2": "200",
 				}
 			)
 			_, err = batch.Exec(col1Data, col2Data, col3Data, col4Data, col5Data)
@@ -89,7 +89,7 @@ func TestStdMap(t *testing.T) {
 				col2 map[string]uint64
 				col3 map[string]uint64
 				col4 []map[string]string
-				col5 map[string]uint64
+				col5 map[string]string
 			)
 			require.NoError(t, conn.QueryRow("SELECT * FROM test_map").Scan(&col1, &col2, &col3, &col4, &col5))
 			assert.Equal(t, col1Data, col1)

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ package std`
`19`	`19`
`20`	`20`	`import (`
`21`	`21`	`"fmt"`
	`22`	`+`
`22`	`23`	`"github.com/ClickHouse/clickhouse-go/v2"`
`23`	`24`	`)`
`24`	`25`
`@@ -33,7 +34,7 @@ func MapInsertRead() error {`
`33`	`34`	`, Col2 Map(String, UInt64)`
`34`	`35`	`, Col3 Map(String, UInt64)`
`35`	`36`	`, Col4 Array(Map(String, String))`
`36`		`- , Col5 Map(LowCardinality(String), LowCardinality(UInt64))`
	`37`	`+ , Col5 Map(LowCardinality(String), LowCardinality(String))`
`37`	`38`	`) Engine Memory`
`38`	`39`	`
`39`	`40`	`conn.Exec("DROP TABLE example")`
`@@ -65,9 +66,9 @@ func MapInsertRead() error {`
`65`	`66`	`{"A": "B"},`
`66`	`67`	`{"C": "D"},`
`67`	`68`	`}`
`68`		`- col5Data = map[string]uint64{`
`69`		`- "key_col_5_1": 100,`
`70`		`- "key_col_5_2": 200,`
	`69`	`+ col5Data = map[string]string{`
	`70`	`+ "key_col_5_1": "100",`
	`71`	`+ "key_col_5_2": "200",`
`71`	`72`	`}`
`72`	`73`	`)`
`73`	`74`	`if _, err := batch.Exec(col1Data, col2Data, col3Data, col4Data, col5Data); err != nil {`
`@@ -81,7 +82,7 @@ func MapInsertRead() error {`
`81`	`82`	`col2 map[string]uint64`
`82`	`83`	`col3 map[string]uint64`
`83`	`84`	`col4 []map[string]string`
`84`		`- col5 map[string]uint64`
	`85`	`+ col5 map[string]string`
`85`	`86`	`)`
`86`	`87`	`if err := conn.QueryRow("SELECT * FROM example").Scan(&col1, &col2, &col3, &col4, &col5); err != nil {`
`87`	`88`	`return err`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ func TestIssue692(t *testing.T) {`
`48`	`48`	`, Col2 Map(String, UInt64)`
`49`	`49`	`, Col3 Map(String, UInt64)`
`50`	`50`	`, Col4 Array(Map(String, String))`
`51`		`- , Col5 Map(LowCardinality(String), LowCardinality(UInt64))`
	`51`	`+ , Col5 Map(LowCardinality(String), LowCardinality(String))`
`52`	`52`	`, Col6 Map(String, Map(String, Int64))`
`53`	`53`	`) Engine MergeTree() ORDER BY tuple()`
`54`	`54`	`
`@@ -77,9 +77,9 @@ func TestIssue692(t *testing.T) {`
`77`	`77`	`{"A": "B"},`
`78`	`78`	`{"C": "D"},`
`79`	`79`	`}`
`80`		`- col5Data = map[string]uint64{`
`81`		`- "key_col_5_1": 100,`
`82`		`- "key_col_5_2": 200,`
	`80`	`+ col5Data = map[string]string{`
	`81`	`+ "key_col_5_1": "100",`
	`82`	`+ "key_col_5_2": "200",`
`83`	`83`	`}`
`84`	`84`	`col6Data = map[string]map[string]int64{}`
`85`	`85`	`)`
`@@ -91,7 +91,7 @@ func TestIssue692(t *testing.T) {`
`91`	`91`	`col2 map[string]uint64`
`92`	`92`	`col3 map[string]uint64`
`93`	`93`	`col4 []map[string]string`
`94`		`- col5 map[string]uint64`
	`94`	`+ col5 map[string]string`
`95`	`95`	`col6 map[string]map[string]int64`
`96`	`96`	`)`
`97`	`97`	`require.NoError(t, conn.QueryRow("SELECT Col1, Col2, Col3, Col4, Col5, Col6 FROM test_map").Scan(&col1, &col2, &col3, &col4, &col5, &col6))`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func TestStdMap(t *testing.T) {`
`50`	`50`	`, Col2 Map(String, UInt64)`
`51`	`51`	`, Col3 Map(String, UInt64)`
`52`	`52`	`, Col4 Array(Map(String, String))`
`53`		`- , Col5 Map(LowCardinality(String), LowCardinality(UInt64))`
	`53`	`+ , Col5 Map(LowCardinality(String), LowCardinality(String))`
`54`	`54`	`) Engine MergeTree() ORDER BY tuple()`
`55`	`55`	`
`56`	`56`	`defer func() {`
`@@ -76,9 +76,9 @@ func TestStdMap(t *testing.T) {`
`76`	`76`	`map[string]string{"A": "B"},`
`77`	`77`	`map[string]string{"C": "D"},`
`78`	`78`	`}`
`79`		`- col5Data = map[string]uint64{`
`80`		`- "key_col_5_1": 100,`
`81`		`- "key_col_5_2": 200,`
	`79`	`+ col5Data = map[string]string{`
	`80`	`+ "key_col_5_1": "100",`
	`81`	`+ "key_col_5_2": "200",`
`82`	`82`	`}`
`83`	`83`	`)`
`84`	`84`	`_, err = batch.Exec(col1Data, col2Data, col3Data, col4Data, col5Data)`
`@@ -89,7 +89,7 @@ func TestStdMap(t *testing.T) {`
`89`	`89`	`col2 map[string]uint64`
`90`	`90`	`col3 map[string]uint64`
`91`	`91`	`col4 []map[string]string`
`92`		`- col5 map[string]uint64`
	`92`	`+ col5 map[string]string`
`93`	`93`	`)`
`94`	`94`	`require.NoError(t, conn.QueryRow("SELECT * FROM test_map").Scan(&col1, &col2, &col3, &col4, &col5))`
`95`	`95`	`assert.Equal(t, col1Data, col1)`