Fix column with double quotes PrepareBatch failed.(#1216) (#1217)

Author: YenchangChan

conn_batch.go

@@ -47,7 +47,9 @@ func (c *connect) prepareBatch(ctx context.Context, query string, opts driver.Pr
 	if len(colMatch) == 2 {
 		columns = strings.Split(colMatch[1], ",")
 		for i := range columns {
-			columns[i] = strings.Trim(strings.TrimSpace(columns[i]), "`\"")
+			// refers to https://clickhouse.com/docs/en/sql-reference/syntax#identifiers
+			// we can use identifiers with double quotes or backticks, for example: "id", `id`, but not both, like `"id"`.
+			columns[i] = strings.Trim(strings.Trim(strings.TrimSpace(columns[i]), "\""), "`")
 		}
 	}
 	if !strings.HasSuffix(strings.TrimSpace(strings.ToUpper(query)), "VALUES") {

tests/issues/1216_test.go

@@ -0,0 +1,31 @@
+package issues
+
+import (
+	"context"
+	"testing"
+
+	"github.com/ClickHouse/clickhouse-go/v2"
+	clickhouse_tests "github.com/ClickHouse/clickhouse-go/v2/tests"
+	"github.com/stretchr/testify/require"
+)
+
+func Test1216(t *testing.T) {
+	var (
+		conn, err = clickhouse_tests.GetConnection("issues", clickhouse.Settings{
+			"max_execution_time":             60,
+			"allow_experimental_object_type": true,
+		}, nil, &clickhouse.Compression{
+			Method: clickhouse.CompressionLZ4,
+		})
+	)
+	ctx := context.Background()
+	require.NoError(t, err)
+	const ddl = "CREATE TABLE IF NOT EXISTS test_1216 (`@id` String,`\"@id_with_quotes\"` String) Engine = Memory"
+	require.NoError(t, conn.Exec(ctx, ddl))
+	defer func() {
+		conn.Exec(ctx, "DROP TABLE IF EXISTS test_1216")
+	}()
+
+	_, err = conn.PrepareBatch(context.Background(), "INSERT INTO test_1216 (`@id`, `\"@id_with_quotes\"`)")
+	require.NoError(t, err)
+}