Merge pull request #1291 from ClickHouse/gg/append_block_lc_fix

Don't recreate keys from LC columns from direct stream

Author: genzgd

lib/column/lowcardinality.go

@@ -220,6 +220,9 @@ func (col *LowCardinality) Encode(buffer *proto.Buffer) {
 	}()
 	ixLen := uint64(len(col.append.index))
 	switch {
+	case col.keys().Rows() > 0:
+		// We already have keys, so this column is probably in a block directly decoded from the server, and we should
+		// not reset them
 	case ixLen < math.MaxUint8:
 		col.key = keyUInt8
 		for _, v := range col.append.keys {

tests/batch_block_test.go

@@ -41,11 +41,11 @@ func TestBatchAppendRows(t *testing.T) {
 	// given we have two tables and a million rows in the source table
 	var tables = []string{"source", "target"}
 	for _, table := range tables {
-		require.NoError(t, conn.Exec(context.Background(), "create table if not exists "+table+" (number1 Int, number2 String, number3 Tuple(String, Int), number4 DateTime) engine = Memory()"))
+		require.NoError(t, conn.Exec(context.Background(), "create table if not exists "+table+" (number1 Int, number2 LowCardinality(String), number3 Tuple(String, Int), number4 DateTime) engine = Memory()"))
 		defer conn.Exec(context.Background(), "drop table if exists "+table)
 	}
 
-	require.NoError(t, conn.Exec(ctx, "INSERT INTO source SELECT number, 'string', tuple('foo', number), now() FROM system.numbers LIMIT 1000000"))
+	require.NoError(t, conn.Exec(ctx, "INSERT INTO source SELECT number, toString(number), tuple('foo', number), now() FROM system.numbers LIMIT 1000000"))
 
 	// when we create a batch with direct data block access 10 times
 	sourceRows, err := conn.Query(ctx, "SELECT * FROM source")