Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Commitment: mirror user's unit preferences from Strava #54

Open
spengrah opened this issue Jun 8, 2021 · 1 comment
Open

Create Commitment: mirror user's unit preferences from Strava #54

spengrah opened this issue Jun 8, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@spengrah
Copy link
Member

spengrah commented Jun 8, 2021

If the Strava API allows, it would be nice to display the user's preferred units (e.g. miles vs. km) from Strava in our app by default.

We probably also need to allow the user to override, so we'd still want the toggle from #30

@spengrah spengrah added the enhancement New feature or request label Jun 8, 2021
@spengrah spengrah added this to the v1.x milestone Jun 8, 2021
@spengrah
Copy link
Member Author

spengrah commented Jun 8, 2021

Good point from @bitbeckers:

but it does interfere with the flow where a commitment could be created without a Strava login. This could be resolved by loggedIn ? noToggle : showToggle

We could also add a setting in your commitpool profile (dashboard?) to set preferred units. Maybe we can also set preferred display currency (eg DAI vs USD vs EUR) there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant