SM-1249: drop vin device def id, make def id not null (#268)

* drop vin device def id, make def id not null

* deprecate elastic search stuff

* wip move vin decoding to definition_id

* all errors for definitionid migration done, deprecate code for elastic and unused cli cmds

* work on test updates

* fix more thigns, tests

* fix more tests

* one last test...

* lint

* lint make mk

* remove more unused code

* test tweak

Author: JamesReate

charts/device-definitions-api/templates/secret.yaml

@@ -35,12 +35,6 @@ spec:
   - remoteRef:
       key: {{ .Release.Namespace }}/devices/redis/password
     secretKey: REDIS_PASSWORD
-  - remoteRef:
-      key: {{ .Release.Namespace }}/devices/elastic/appsearch/host
-    secretKey: ELASTIC_SEARCH_APP_SEARCH_HOST
-  - remoteRef:
-      key: {{ .Release.Namespace }}/devices/elastic/appsearch/token
-    secretKey: ELASTIC_SEARCH_APP_SEARCH_TOKEN
   - remoteRef:
       key: {{ .Release.Namespace }}/definitions/elastic/device_status/host
     secretKey: ELASTIC_SEARCH_DEVICE_STATUS_HOST

charts/device-definitions-api/values-prod.yaml

@@ -62,9 +62,4 @@ jobs:
     schedule: 0 0 * * 1
     args:
       - '-c'
-      - /device-definitions-api sync-device-definitions-search; CODE=$?; echo "weekly typesense mmy search index sync completed"; wget -q --post-data "hello=shutdown" http://localhost:4191/shutdown &> /dev/null; exit $CODE;
-  - name: feat-compat-updte
-    schedule: 0 0 * * 0
-    args:
-      - '-c'
-      - /device-definitions-api populate-device-features; CODE=$?; echo "weekly integration features update completed"; wget -q --post-data "hello=shutdown" http://localhost:4191/shutdown &> /dev/null; exit $CODE;
+      - /device-definitions-api sync-device-definitions-search; CODE=$?; echo "weekly typesense mmy search index sync completed"; wget -q --post-data "hello=shutdown" http://localhost:4191/shutdown &> /dev/null; exit $CODE;

charts/device-definitions-api/values.yaml

@@ -47,7 +47,6 @@ env:
   DRIVLY_OFFER_API_URL: https://offers.dev.driv.ly
   FUEL_API_VEHICLES_ENDPOINT: https://api.fuelapi.com/v1/json/vehicles
   FUEL_API_IMAGES_ENDPOINT: https://api.fuelapi.com/v1/json/vehicle
-  NHTSA_RECALLS_FILE_URL: https://static.nhtsa.gov/odi/ffdd/rcl/FLAT_RCL.zip
   VINCARIO_API_URL: https://api.vindecoder.eu/3.2
   DAT_GROUP_URL: https://www.datgroup.com/myClaim/soap/v2/VehicleIdentificationService
   PRIVATE_KEY_MODE: false

cmd/device-definitions-api/add_vin.go

@@ -104,7 +104,7 @@ func (p *addVINCmd) Execute(ctx context.Context, _ *flag.FlagSet, _ ...interface
 		fmt.Println(err.Error() + " " + model + " " + strconv.Itoa(vinNumber.Year))
 		return subcommands.ExitFailure
 	}
-	vinNumber.DeviceDefinitionID = deviceDefinition.ID
+	vinNumber.DefinitionID = deviceDefinition.NameSlug
 
 	err = vinNumber.Insert(ctx, pdb.DBS().Writer, boil.Infer())
 	if err != nil {
@@ -113,7 +113,7 @@ func (p *addVINCmd) Execute(ctx context.Context, _ *flag.FlagSet, _ ...interface
 	}
 
 	// improvement, from existing data, try to guess Model
-	fmt.Printf("added success, ddId: %s\n", vinNumber.DeviceDefinitionID)
+	fmt.Printf("added success, ddId: %s\n", vinNumber.DefinitionID)
 	return subcommands.ExitSuccess
 }
 

cmd/device-definitions-api/main.go

@@ -49,10 +49,8 @@ func main() {
 	subcommands.Register(&migrateDBCmd{logger: logger, settings: settings}, "")
 	subcommands.Register(&syncOpsCmd{logger: logger, settings: settings}, "")
 	subcommands.Register(&syncFuelImageCmd{logger: logger, settings: settings}, "")
-	subcommands.Register(&syncDeviceFeatureCmd{logger: logger, settings: settings}, "")
 	subcommands.Register(&addVINCmd{logger: logger, settings: settings}, "")
 	subcommands.Register(&powerTrainTypeCmd{logger: logger, settings: settings}, "")
-	subcommands.Register(&setVinNumbersDefinitionID{logger: logger, settings: settings}, "")
 	subcommands.Register(&decodeVINCmd{logger: &logger, settings: &settings}, "")
 	subcommands.Register(&syncDeviceDefinitionSearchCmd{logger: logger, settings: settings}, "")
 	subcommands.Register(&bulkCreateDefinitions{logger: logger, settings: settings}, "")