Skip to content

Commit f0120e4

Browse files
author
Corentin Mors
authored
Sign Windows build and bump version (#203)
Use code signing for our Windows build.
1 parent 8368d87 commit f0120e4

10 files changed

+2636
-3002
lines changed

.github/workflows/release.yml

+35-1
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,44 @@ jobs:
4141
path: bundle/dcli-${{ matrix.settings.target }}${{ matrix.settings.extension }}
4242
retention-days: 1
4343

44-
release:
44+
sign:
4545
runs-on: ubuntu-latest
4646
needs: build
47+
steps:
48+
- name: Sign Artifact with CodeSignTool
49+
uses: sslcom/esigner-codesign@develop
50+
with:
51+
command: sign
52+
username: ${{ secrets.ES_USERNAME }}
53+
password: ${{ secrets.ES_PASSWORD }}
54+
# Credential ID for signing certificate.
55+
credential_id: ${{ secrets.CREDENTIAL_ID }}
56+
# OAuth TOTP Secret (https://www.ssl.com/how-to/automate-esigner-ev-code-signing)
57+
totp_secret: ${{ secrets.ES_TOTP_SECRET }}
58+
# Path of code object to be signed
59+
file_path: ${GITHUB_WORKSPACE}/bundle/dcli-win-x64.exe
60+
# Directory where signed code object(s) will be written.
61+
output_path: ${GITHUB_WORKSPACE}/signed
62+
malware_block: false
63+
environment_name: PROD
64+
65+
- run: mv signed/dcli-win-x64.exe signed/dcli-win-x64-signed.exe
66+
67+
- name: Archive binary artifact
68+
uses: actions/upload-artifact@v3
69+
with:
70+
name: dcli-win-x64-signed
71+
path: signed/dcli-win-x64-signed.exe
72+
retention-days: 1
73+
74+
release:
75+
runs-on: ubuntu-latest
76+
needs:
77+
- build
78+
- sign
4779
steps:
4880
- uses: actions/checkout@v3
81+
4982
- name: Download all artifacts
5083
uses: actions/download-artifact@v3
5184
with:
@@ -62,3 +95,4 @@ jobs:
6295
artifacts/dcli-linux-x64/dcli-linux-x64
6396
artifacts/dcli-macos-x64/dcli-macos-x64
6497
artifacts/dcli-win-x64/dcli-win-x64.exe
98+
artifacts/dcli-win-x64-signed/dcli-win-x64-signed.exe

.mocharc.json

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
2-
"extension": ["ts"],
3-
"spec": "src/**/test.ts",
4-
"loader": "ts-node/esm"
2+
"extension": ["ts"],
3+
"spec": "src/**/test.ts",
4+
"loader": "ts-node/esm",
5+
"require": ["ts-node/register"]
56
}

.yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs

-541
This file was deleted.

.yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs

-28
This file was deleted.

.yarn/releases/yarn-3.6.3.cjs

-874
This file was deleted.

.yarn/releases/yarn-4.0.2.cjs

+893
Large diffs are not rendered by default.

.yarnrc.yml

+5-7
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
1-
nodeLinker: node-modules
1+
compressionLevel: mixed
2+
3+
enableGlobalCache: false
24

3-
plugins:
4-
- path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
5-
spec: "@yarnpkg/plugin-workspace-tools"
6-
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
7-
spec: "@yarnpkg/plugin-interactive-tools"
5+
nodeLinker: node-modules
86

9-
yarnPath: .yarn/releases/yarn-3.6.3.cjs
7+
yarnPath: .yarn/releases/yarn-4.0.2.cjs

package.json

+23-23
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@dashlane/cli",
3-
"version": "1.15.1",
3+
"version": "1.15.2",
44
"description": "Manage your Dashlane vault through a CLI tool",
55
"main": "dist/index.js",
66
"types": "dist/index.d.ts",
@@ -38,46 +38,46 @@
3838
"contributors": [],
3939
"license": "Apache-2.0",
4040
"devDependencies": {
41-
"@types/async": "^3.2.20",
42-
"@types/better-sqlite3": "^7.6.4",
43-
"@types/chai": "^4.3.6",
44-
"@types/inquirer": "^8.2.6",
45-
"@types/mocha": "^10.0.1",
46-
"@types/node": "^18.17.14",
47-
"@typescript-eslint/eslint-plugin": "^6.6.0",
48-
"@typescript-eslint/parser": "^6.6.0",
49-
"chai": "^4.3.8",
50-
"eslint": "^8.48.0",
51-
"eslint-config-prettier": "^9.0.0",
52-
"eslint-plugin-import": "^2.28.1",
41+
"@types/async": "^3.2.24",
42+
"@types/better-sqlite3": "^7.6.8",
43+
"@types/chai": "^4.3.11",
44+
"@types/inquirer": "^8.2.10",
45+
"@types/mocha": "^10.0.6",
46+
"@types/node": "^18.19.7",
47+
"@typescript-eslint/eslint-plugin": "^6.19.0",
48+
"@typescript-eslint/parser": "^6.19.0",
49+
"chai": "^4.4.1",
50+
"eslint": "^8.56.0",
51+
"eslint-config-prettier": "^9.1.0",
52+
"eslint-plugin-import": "^2.29.1",
5353
"husky": "^8.0.3",
5454
"mocha": "^10.2.0",
5555
"pkg": "^5.8.1",
5656
"prettier": "^3.0.3",
57-
"ts-node": "^10.9.1",
57+
"ts-node": "^10.9.2",
5858
"typescript": "^5.2.2"
5959
},
6060
"dependencies": {
61-
"@json2csv/plainjs": "^7.0.3",
62-
"@json2csv/transforms": "^7.0.3",
61+
"@json2csv/plainjs": "^7.0.4",
62+
"@json2csv/transforms": "^7.0.4",
6363
"@napi-rs/clipboard": "^1.1.1",
6464
"@napi-rs/keyring": "^1.1.3",
65-
"@node-rs/argon2": "^1.5.2",
66-
"better-sqlite3": "^8.6.0",
67-
"commander": "^11.0.0",
65+
"@node-rs/argon2": "^1.7.1",
66+
"better-sqlite3": "^8.7.0",
67+
"commander": "^11.1.0",
6868
"got": "^11.8.6",
6969
"inquirer": "^8.2.6",
7070
"inquirer-search-list": "^1.2.6",
7171
"jsonpath-plus": "^7.2.0",
7272
"otplib": "^12.0.1",
73-
"playwright-core": "^1.37.1",
74-
"winston": "^3.10.0",
73+
"playwright-core": "^1.40.1",
74+
"winston": "^3.11.0",
7575
"xml-js": "^1.6.11",
7676
"zlib": "^1.0.5"
7777
},
7878
"engines": {
7979
"node": ">=18",
80-
"yarn": ">=3.6.0"
80+
"yarn": ">=4.0.0"
8181
},
82-
"packageManager": "yarn@3.6.3"
82+
"packageManager": "yarn@4.0.2"
8383
}

src/cliVersion.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { CliVersion } from './types';
22

3-
export const CLI_VERSION: CliVersion = { major: 1, minor: 15, patch: 1 };
3+
export const CLI_VERSION: CliVersion = { major: 1, minor: 15, patch: 2 };
44
export const breakingChangesVersions: CliVersion[] = [];
55

66
export const cliVersionToString = (version: CliVersion): string => {

0 commit comments

Comments
 (0)