Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dda inv install-tools fails with Go 1.24.2 #35779

Open
ravelox opened this issue Apr 3, 2025 · 1 comment
Open

[BUG] dda inv install-tools fails with Go 1.24.2 #35779

ravelox opened this issue Apr 3, 2025 · 1 comment

Comments

@ravelox
Copy link

ravelox commented Apr 3, 2025

Following the build instructions for datadog-agent using Go 1.24.2 in README.md, dda inv install-tools generates the following errors:

(.venv) root@vmubuntu:/usr/local/go/src/github.com/DataDog/datadog-agent# dda inv install-tools
go: error loading go.work:
../../go.work:9: unknown godebug "tlskyber"
[1 / 3] Failed running command go install github.com/frapposelli/wwhrd, retrying in 10 seconds
go: error loading go.work:
../../go.work:9: unknown godebug "tlskyber"
[2 / 3] Failed running command go install github.com/frapposelli/wwhrd, retrying in 100 seconds
^X^C
Aborted.

This appears to be related to golang/go#72111

Using Go 1.23.8 works without errors.

Agent Environment
Not applicable

Describe what happened:
When running 'dda inv install-tools' in the virtual environment, the above errors are seen.

Describe what you expected:
No errors.

Steps to reproduce the issue:

  1. install Go 1.24.2

  2. Clone datadog-agent repository
    git clone https://github.com/DataDog/datadog-agent.git $GOPATH/src/github.com/DataDog/datadog-agent
    Cloning into '/usr/local/go/src/github.com/DataDog/datadog-agent'...
    remote: Enumerating objects: 572583, done.
    remote: Counting objects: 100% (3558/3558), done.
    remote: Compressing objects: 100% (1635/1635), done.
    remote: Total 572583 (delta 2960), reused 1923 (delta 1923), pack-reused 569025 (from 4)
    Receiving objects: 100% (572583/572583), 480.04 MiB | 28.57 MiB/s, done.
    Resolving deltas: 100% (434703/434703), done.
    Updating files: 100% (14704/14704), done.

  3. Create virtual environment
    root@vmubuntu:~# cd /usr/local/go/src/github.com/Datadog/datadog-agent
    root@vmubuntu:/usr/local/go/src/github.com/DataDog/datadog-agent# python3 -mvenv .venv
    root@vmubuntu:/usr/local/go/src/github.com/DataDog/datadog-agent# source .venv/bin/activate

  4. Install dda
    (.venv) root@vmubuntu:/usr/local/go/src/github.com/DataDog/datadog-agent# pip install dda

  5. Add Go to $PATH
    (.venv) root@vmubuntu:/usr/local/go/src/github.com/DataDog/datadog-agent# export PATH=$PATH:/usr/local/go/bin

  6. Run dda inv install-tools

(.venv) root@vmubuntu:/usr/local/go/src/github.com/DataDog/datadog-agent# dda inv install-tools
go: error loading go.work:
../../go.work:9: unknown godebug "tlskyber"
[1 / 3] Failed running command go install github.com/frapposelli/wwhrd, retrying in 10 seconds
go: error loading go.work:
../../go.work:9: unknown godebug "tlskyber"
[2 / 3] Failed running command go install github.com/frapposelli/wwhrd, retrying in 100 seconds
^X^C
Aborted.

@pgimalac
Copy link
Member

pgimalac commented Apr 3, 2025

Thanks for opening an issue, this is known, as you've seen we're discussing with upstream to get that fixed (golang/go#72111), the best workaround is to export GOTOOLCHAIN=go1.23.8 env variable, it will dynamically downgrade Go to that version when running go commands (and Go 1.23 knows what tlskyber is).
Sorry for the inconvenience...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants