Skip to content

Commit 41e3673

Browse files
chore: Add yamllint to make all (open-telemetry#1707)
* chore: Add yamllint to `make all` * Fix makefile syntax --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
1 parent 23e48ce commit 41e3673

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ the release.
99

1010
* [accountingservice] allow running the container with non root user
1111
([#1692](https://github.com/open-telemetry/opentelemetry-demo/pull/1692))
12+
* [chore] Add yamllint to `make all`
13+
([#1707](https://github.com/open-telemetry/opentelemetry-demo/pull/1707))
1214

1315
## 1.11.1
1416

Makefile

+4-4
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ DOCKER_COMPOSE_ENV=--env-file .env --env-file .env.override
1616
# see https://github.com/open-telemetry/build-tools/releases for semconvgen updates
1717
# Keep links in semantic_conventions/README.md and .vscode/settings.json in sync!
1818
SEMCONVGEN_VERSION=0.11.0
19+
YAMLLINT_VERSION=1.30.0
1920

20-
# TODO: add `yamllint` step to `all` after making sure it works on Mac.
2121
.PHONY: all
22-
all: install-tools markdownlint misspell
22+
all: install-tools markdownlint misspell yamllint
2323

2424
$(MISSPELL):
2525
cd $(TOOLS_DIR) && go build -o $(MISSPELL_BINARY) github.com/client9/misspell/cmd/misspell
@@ -44,10 +44,10 @@ markdownlint:
4444
.PHONY: install-yamllint
4545
install-yamllint:
4646
# Using a venv is recommended
47-
pip install -U yamllint~=1.30.0
47+
yamllint --version >/dev/null 2>&1 || pip install -U yamllint~=$(YAMLLINT_VERSION)
4848

4949
.PHONY: yamllint
50-
yamllint:
50+
yamllint: install-yamllint
5151
yamllint .
5252

5353
.PHONY: checklicense

0 commit comments

Comments
 (0)