Skip to content

Commit 54b1833

Browse files
Fixes #892
1 parent 9e8e0b4 commit 54b1833

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/main/java/org/dependencytrack/persistence/QueryManager.java

+10-6
Original file line numberDiff line numberDiff line change
@@ -1125,9 +1125,11 @@ public List<PolicyViolation> getAllPolicyViolations(final Project project) {
11251125
*/
11261126
@SuppressWarnings("unchecked")
11271127
public PaginatedResult getPolicyViolations(final Project project, boolean includeSuppressed) {
1128-
final Query<PolicyViolation> query = pm.newQuery(PolicyViolation.class, "project.id == :pid");
1129-
if (!includeSuppressed) {
1130-
query.setFilter("analysis.suppressed == false || analysis.suppressed == null");
1128+
final Query<PolicyViolation> query = pm.newQuery(PolicyViolation.class);
1129+
if (includeSuppressed) {
1130+
query.setFilter("project.id == :pid");
1131+
} else {
1132+
query.setFilter("project.id == :pid && (analysis.suppressed == false || analysis.suppressed == null)");
11311133
}
11321134
if (orderBy == null) {
11331135
query.setOrdering("timestamp desc, component.name, component.version");
@@ -1148,9 +1150,11 @@ public PaginatedResult getPolicyViolations(final Project project, boolean includ
11481150
*/
11491151
@SuppressWarnings("unchecked")
11501152
public PaginatedResult getPolicyViolations(final Component component, boolean includeSuppressed) {
1151-
final Query<PolicyViolation> query = pm.newQuery(PolicyViolation.class, "component.id == :cid");
1152-
if (!includeSuppressed) {
1153-
query.setFilter("analysis.suppressed == false || analysis.suppressed == null");
1153+
final Query<PolicyViolation> query = pm.newQuery(PolicyViolation.class);
1154+
if (includeSuppressed) {
1155+
query.setFilter("component.id == :cid");
1156+
} else {
1157+
query.setFilter("component.id == :cid && (analysis.suppressed == false || analysis.suppressed == null)");
11541158
}
11551159
if (orderBy == null) {
11561160
query.setOrdering("timestamp desc");

0 commit comments

Comments
 (0)