Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak: dispose() does not delete instance #186

Open
Corvus278 opened this issue Jun 20, 2023 · 1 comment
Open

Memory leak: dispose() does not delete instance #186

Corvus278 opened this issue Jun 20, 2023 · 1 comment

Comments

@Corvus278
Copy link

In the params field of each instance there is an index field, which stores the index of the instance in the array of instances, by which it will be deleted from there after instanse.dispose(). Index is obtained from the data-attribute node of the scroller element. However, in data-attribute, the index is put in the init function, and it is obtained in the baron function BEFORE init. If an instance is created for a new scroller, the scroller does not have a data-attribute with an index, and 0 is written to instance.params.index.

@Corvus278
Copy link
Author

Fix it in PR - #187

@Corvus278 Corvus278 reopened this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant