Add call confirmation request

Now VISOR can FINALLY have interactive commands. The first dynamic one
was the contacts one. Now all can be interactive. He will request a user
confirmation before calling any number. 2 new commands were added for
this: a confirmation one, and a rejection one. There is no need to
explicitly reject a command though - it will be rejected in 60 seconds
if there's no confirmation.

Updated the makePhoneCall() function to say why it could not place a
call (no permission to call any number or just emergency numbers?).

Removed the forced permissions and authorizations (again).

Author: Edw590

app/src/main/java/com/dadi590/assist_c_a/GlobalUtils/AndroidSystem/UtilsAndroid.java

@@ -47,4 +47,7 @@ private UtilsAndroid() {
 	public static final int MODE_RECOVERY = -987678;
 	public static final int MODE_BOOTLOADER = -987679;
 	public static final int MODE_FAST = -987680;
+
+	public static final int NO_CALL_EMERGENCY = -987681;
+	public static final int NO_CALL_ANY = -987682;
 }

app/src/main/java/com/dadi590/assist_c_a/GlobalUtils/AndroidSystem/UtilsAndroidTelephony.java

@@ -183,47 +183,50 @@ public static void setCallSpeakerphoneEnabled(final boolean enabled) {
 
 	/**
 	 * <p>Places a phone call.</p>
-	 * <p>If the app is a privileged system app, it is possible to call emergency numbers - do not attempt without being
-	 * such an app, or a security exception will be thrown and not handled.</p>
+	 * <br>
+	 * <p><u>---CONSTANTS---</u></p>
+	 * <p>- {@link UtilsAndroid#NO_ERR} --> for the returning value: if the operation completed successfully</p>
+	 * <p>- {@link UtilsAndroid#NO_CALL_ANY} --> for the returning value: no permission to call numbers</p>
+	 * <p>- {@link UtilsAndroid#NO_CALL_EMERGENCY} --> for the returning value: no permission to call emergency numbers</p>
+	 * <p><u>---CONSTANTS---</u></p>
 	 *
-	 * @param phone_number the phone number to call, with country prefix (for example, +351123456789 or +351112 for
-	 *                     Portugal)
+	 * @param phone_number the phone number to call
 	 *
-	 * @return true if the call was placed, false if it was just dialed because there are not enough permissions to
-	 * place the call (either because there's no permission to place calls, or there's no permission to place emergency
-	 * calls)
+	 * @return one of the constants
 	 */
-	public static boolean makePhoneCall(@NonNull final String phone_number) {
+	public static int makePhoneCall(@NonNull final String phone_number) {
 		final Context context = UtilsGeneral.getContext();
 
 		final Intent intent = new Intent("", Uri.fromParts("tel", phone_number, null));
 
-		// I think below Android 11, ACTION_DIAL can be used to dial emergency numbers (haven't tested it yet though).
-		final String action_dial_emergency = Build.VERSION.SDK_INT >= Build.VERSION_CODES.R ?
-				Intent.ACTION_DIAL_EMERGENCY : Intent.ACTION_DIAL;
+		// On 2023-02-01, Android Developers says ACTION_DIAL can be used for emergency numbers (so at least until
+		// Android 12 it's like this).
+		final String action_dial_emergency = Intent.ACTION_DIAL;
+		final boolean is_potentially_emergency_number = UtilsTelephony.isPotentialEmergencyNumber(phone_number);
 
 		final String action;
-		final boolean call_placed;
+		final int return_code;
 		if (UtilsPermsAuths.checkSelfPermission(Manifest.permission.CALL_PRIVILEGED)) {
+			// As written on the AOSP code for ACTION_CALL_PRIVILEGED:
+			// "Perform a call to any number (emergency or not) specified by the data."
 			action = Intent.ACTION_CALL_PRIVILEGED;
-			call_placed = true;
+			return_code = UtilsAndroid.NO_ERR;
 		} else if (UtilsPermsAuths.checkSelfPermission(Manifest.permission.CALL_PHONE)) {
-			if (UtilsTelephony.isEmergencyNumber(phone_number)) {
+			if (is_potentially_emergency_number) {
 				action = action_dial_emergency;
-				call_placed = false;
+				return_code = UtilsAndroid.NO_CALL_EMERGENCY;
 			} else {
 				action = Intent.ACTION_CALL;
-				call_placed = true;
+				return_code = UtilsAndroid.NO_ERR;
 			}
 		} else {
-			action = UtilsTelephony.isEmergencyNumber(phone_number) ? action_dial_emergency : Intent.ACTION_DIAL;
-			call_placed = false;
+			action = is_potentially_emergency_number ? action_dial_emergency : Intent.ACTION_DIAL;
+			return_code = UtilsAndroid.NO_CALL_ANY;
 		}
-
 		intent.setAction(action);
 		intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
 		context.startActivity(intent);
 
-		return call_placed;
+		return return_code;
 	}
 }

app/src/main/java/com/dadi590/assist_c_a/GlobalUtils/UtilsPermsAuths.java

@@ -22,6 +22,7 @@
 package com.dadi590.assist_c_a.GlobalUtils;
 
 import android.app.Activity;
+import android.app.AppOpsManager;
 import android.app.NotificationManager;
 import android.content.ComponentName;
 import android.content.Context;
@@ -116,7 +117,7 @@ public static int checkRequestPerms(@Nullable final Activity activity, final boo
 
 		final String [][][] list_to_use = PERMS_CONSTS.list_of_perms_lists;
 		final int list_to_use_len = list_to_use.length;
-		final boolean force_permissions = (request && activity == null);
+		final boolean force_permissions = false;// todo (request && activity == null); - same reason on the auths function
 		int num_not_granted_perms = 0;
 
 		int array_length = 0;
@@ -209,7 +210,11 @@ public static int checkRequestAuths(int what_to_do) {
 		final String package_name = context.getPackageName();
 		int missing_authorizations = 0;
 
-		// todo Remove the comments when you make a way to request VISOR to stop requesting specific permissions
+		// todo Remove this when you make a way to request VISOR to stop requesting specific permissions
+		// Also I can't test stuff with this thing forcing all auths and perms to be granted...
+		if (ALSO_FORCE == what_to_do) {
+			what_to_do = CHECK_ONLY;
+		}
 
 		if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
 			// Check if the DND management policy access has been granted for the app and if not, open the settings
@@ -218,10 +223,10 @@ public static int checkRequestAuths(int what_to_do) {
 					getSystemService(Context.NOTIFICATION_SERVICE);
 			if (!mNotificationManager.isNotificationPolicyAccessGranted()) {
 				if (ALSO_FORCE == what_to_do) {
-					/*final String command = "cmd notification allow_dnd " + package_name;
+					final String command = "cmd notification allow_dnd " + package_name;
 					UtilsShell.executeShellCmd(command, false, true);
 
-					missing_authorizations += mNotificationManager.isNotificationPolicyAccessGranted() ? 0 : 1;*/
+					missing_authorizations += mNotificationManager.isNotificationPolicyAccessGranted() ? 0 : 1;
 				} else {
 					++missing_authorizations;
 
@@ -236,11 +241,11 @@ public static int checkRequestAuths(int what_to_do) {
 			// Check if the app can draw system overlays and open the settings screen if not
 			if (!Settings.canDrawOverlays(context)) {
 				if (ALSO_FORCE == what_to_do) {
-					/*final String command = "appops set " + package_name + " " + AppOpsManager.OP_SYSTEM_ALERT_WINDOW +
+					final String command = "appops set " + package_name + " " + AppOpsManager.OP_SYSTEM_ALERT_WINDOW +
 							" allow";
 					UtilsShell.executeShellCmd(command, false, true);
 
-					missing_authorizations += Settings.canDrawOverlays(context) ? 0 : 1;*/
+					missing_authorizations += Settings.canDrawOverlays(context) ? 0 : 1;
 				} else {
 					++missing_authorizations;
 
@@ -257,10 +262,10 @@ public static int checkRequestAuths(int what_to_do) {
 			final PowerManager powerManager = (PowerManager) context.getSystemService(Context.POWER_SERVICE);
 			if (!powerManager.isIgnoringBatteryOptimizations(package_name)) {
 				if (ALSO_FORCE == what_to_do) {
-					/*final String command = "dumpsys deviceidle whitelist +" + package_name;
+					final String command = "dumpsys deviceidle whitelist +" + package_name;
 					UtilsShell.executeShellCmd(command, false, true);
 
-					missing_authorizations += powerManager.isIgnoringBatteryOptimizations(package_name) ? 0 : 1;*/
+					missing_authorizations += powerManager.isIgnoringBatteryOptimizations(package_name) ? 0 : 1;
 				} else {
 					++missing_authorizations;
 
@@ -277,11 +282,11 @@ public static int checkRequestAuths(int what_to_do) {
 			// Check if the app has the WRITE_SETTINGS permission and request it if not
 			if (!Settings.System.canWrite(context)) {
 				if (ALSO_FORCE == what_to_do) {
-					/*final String command = "appops set " + package_name + " " + AppOpsManager.OP_WRITE_SETTINGS +
+					final String command = "appops set " + package_name + " " + AppOpsManager.OP_WRITE_SETTINGS +
 							" allow";
 					UtilsShell.executeShellCmd(command, false, true);
 
-					missing_authorizations += Settings.System.canWrite(context) ? 0 : 1;*/
+					missing_authorizations += Settings.System.canWrite(context) ? 0 : 1;
 				} else {
 					++missing_authorizations;
 
@@ -298,9 +303,9 @@ public static int checkRequestAuths(int what_to_do) {
 
 		if (!UtilsApp.isDeviceAdmin()) {
 			if (ALSO_FORCE == what_to_do) {
-				/*forceDeviceAdmin();
+				forceDeviceAdmin();
 
-				missing_authorizations += UtilsApp.isDeviceAdmin() ? 0 : 1;*/
+				missing_authorizations += UtilsApp.isDeviceAdmin() ? 0 : 1;
 			} else {
 				++missing_authorizations;