Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fine-grained control over ignoring specific issues to allow upstream crates to update #754

Open
gsson opened this issue Mar 11, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@gsson
Copy link

gsson commented Mar 11, 2025

Is your feature request related to a problem? Please describe.

I have a transitive dependency on the Protobuf crate, which is currently affected by RUSTSEC-2024-0437

It is not likely that the upstreams (prometheus, opentelemetry-prometheus) will update the dependency in the next little while (as they are not directly vulnerable), but I would not want to "perma-ignore" the issue. As it is currently used by the upstream dependencies it seems to be harmless, but I wouldn't want it to be pulled in accidentally by some new code or dependency.

Describe the solution you'd like

I would like the ability to ignore the issue until the upstreams have had a chance to repair.

It would be nice if I could either

Currently I am adding something like this

ignore = [
    { id = "RUSTSEC-2024-0437", reason = "...(explanation)..." },
]

I would like to be able to add something like (the actual vulnerable crate is protobuf, but I only want to allow the prometheus and opentelemetry-prometheus to use the vulnerable version)

ignore = [
    { id = "RUSTSEC-2024-0437", reason = "...(explanation)...", from = "prometheus@..."},
    { id = "RUSTSEC-2024-0437", reason = "...(explanation)...", from = "opentelemetry-prometheus@..."},
]

and/or

ignore = [
    { id = "RUSTSEC-2024-0437", reason = "...(explanation)...", until="2025-04-11"}
]

Describe alternatives you've considered

I am currently just ignoring the issue, but that leaves the other other crates (transitive or not) open to accidentally pull in the vulnerable protobuf version in the future.

Additional context

I saw a similar issue was filed in #345 , but I think this use-case is different enough to warrant a separate issue (if only to document the reasons not to do it)

@gsson gsson added the enhancement New feature or request label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant