Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLSearchParams no longer exported by "svelte/reactivity" #12

Closed
6 tasks done
mrbelderock opened this issue Oct 3, 2024 · 1 comment
Closed
6 tasks done

URLSearchParams no longer exported by "svelte/reactivity" #12

mrbelderock opened this issue Oct 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mrbelderock
Copy link

Describe the bug

It looks like this library is looking for a URLSearchParams object from "svelte/reactivity", which I think no longer exists. Svelte now exports a reactive "SvelteURL".

I'm guessing the constant updates to Svelte 5 RC have broken this lib?

It looks super useful otherwise! Hard to believe Svelte doesn't have capability built in for syncing state easily with URLSearchParams.

Reproduction

Start new Svelte5 project, follow instructions from the docs. (I'm using Deno, but that shouldn't matter.)

Breaks with:

No matching export in "node_modules/.deno/svelte@5.0.0-next.259/node_modules/svelte/src/reactivity/index-client.js" for import "URLSearchParams"

node_modules/.deno/svelte-query-params@0.2.3/node_modules/svelte-query-params/dist/index.svelte.js:24:9:
  24 │ import { URLSearchParams as reactive_URLSearchParams } from "svelte/reactivity";

System Info

Deno 2.00 rc5

Used Package Manager

npm

Validations

@Ernxst Ernxst self-assigned this Oct 3, 2024
@Ernxst Ernxst added the bug Something isn't working label Oct 3, 2024
@Ernxst
Copy link
Owner

Ernxst commented Oct 3, 2024

Hey, thanks for checking out the library!

There was a leftover todo because svelte renamed an exported class (see this release) and I was originally planning to wait until rc to make this change, but it seems it's been stable for quite a while now. This should be fixed in 0.2.4.

@Ernxst Ernxst closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants