Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release and broken links #21

Open
poautran opened this issue Feb 24, 2025 · 2 comments
Open

New release and broken links #21

poautran opened this issue Feb 24, 2025 · 2 comments

Comments

@poautran
Copy link

poautran commented Feb 24, 2025

Hi Axel!

We are looking at deploying this package on the ESRF cluster in a Conda env with py3.12.
Could you make a release on pypi with your latest changes ? It seems like the version 0.4.1 is kind of outdated.
Also the links on pypi are pointing to a fork of the project in your homespace.

Note: pygalmesh seems like a dead project, we may have issues to make it work on py3.12. Do you have any alternatives already in mind ?

Thanks for your help ;-)

@AxelHenningsson
Copy link
Collaborator

Hi Pierre!

Thanks for showing an interest!

I belive @Marcraven should be in this discussion as he currently have a heavily optimised version of the library on his branch which he is actively developing as part of his professional work -- This is the time to make a decision about merging branches and releasing a v1.0.0 xrd_simulator. @Marcraven would you like to merge into main and release you contributions?

In terms of pygalmesh I do not currently have an option available. The lib is basically a bunch of bindings to cgal as fars I understand. I would expect it to run on python 3.12?

@Marcraven
Copy link
Collaborator

Marcraven commented Mar 2, 2025

Hi Axel,

I think I would like to add my branch as xrd_simulator.powder, separare code within the xrd_simulator project.

The code is already so different from the original that trying to keep all the functions common is pointless.

What I can try is to keep the API for users as similar as possible.

That is really all I can offer, if you think it is a good idea maybe we should then name the classic xrd_simulator.crystals or something like that so people know which package is good for what.

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants