fix: license bug when dataset supplies a list or None

Author: AhmetNSimsek

siibra/core/concept.py

@@ -101,7 +101,15 @@ def description(self):
 
     @property
     def LICENSE(self) -> str:
-        return '\n'.join([ds.LICENSE for ds in self.datasets])
+        licenses = []
+        for ds in self.datasets:
+            if ds.LICENSE is None or ds.LICENSE == "No license information is found.":
+                continue
+            if isinstance(ds.LICENSE, str):
+                licenses.append(ds.LICENSE)
+            if isinstance(ds.LICENSE, list):
+                licenses.extend(ds.LICENSE)
+        return '\n'.join(licenses)
 
     @property
     def doi_or_url(self) -> str:

siibra/features/feature.py

@@ -164,7 +164,15 @@ def description(self):
 
     @property
     def LICENSE(self) -> str:
-        return '\n'.join([ds.LICENSE for ds in self.datasets])
+        licenses = []
+        for ds in self.datasets:
+            if ds.LICENSE is None or ds.LICENSE == "No license information is found.":
+                continue
+            if isinstance(ds.LICENSE, str):
+                licenses.append(ds.LICENSE)
+            if isinstance(ds.LICENSE, list):
+                licenses.extend(ds.LICENSE)
+        return '\n'.join(licenses)
 
     @property
     def doi_or_url(self) -> str:

siibra/retrieval/datasets.py

@@ -56,6 +56,10 @@ def id(self) -> str:
     def name(self) -> str:
         raise NotImplementedError
 
+    @abstractproperty
+    def LICENSE(self) -> List[str]:
+        raise NotImplementedError
+
     @abstractproperty
     def urls(self) -> List[EbrainsDatasetUrl]:
         raise NotImplementedError