Improve CeleryScript support for resource variables in Lua

Author: RickCarlino

lib/celery/compilers/variable_transformer.ex

@@ -2,6 +2,9 @@
 # an x/y/z property at the root of the object.
 defmodule FarmbotOS.Celery.Compiler.VariableTransformer do
   alias FarmbotOS.Celery.SysCallGlue
+  alias FarmbotOS.Asset.Repo
+
+  require FarmbotOS.Logger
 
   def run!(%{resource_id: id, resource_type: t}) do
     [SysCallGlue.point(t, id)]
@@ -34,6 +37,27 @@ defmodule FarmbotOS.Celery.Compiler.VariableTransformer do
     [%{kind: :error, error: error, x: nil, y: nil, z: nil}, error]
   end
 
+  def run!(%{args: %{resource_id: id, resource_type: t}} = misc) do
+    mod = Module.concat(FarmbotOS.Asset, t)
+    is_known_resource? = Kernel.function_exported?(mod, :render, 1)
+
+    if is_known_resource? do
+      result = Repo.get_by(mod, id: id)
+
+      if result do
+        [result]
+      else
+        msg = "Could not find #{t} #{id}. Did you delete it?"
+        FarmbotOS.Logger.info(3, msg)
+        [nil]
+      end
+    else
+      # There was a typo, or the sequence is handling a resource
+      # that FarmBot OS does not know about.
+      [misc]
+    end
+  end
+
   def run!(other) do
     [other]
   end

test/celery/variable_transformer_test.exs

@@ -62,4 +62,24 @@ defmodule FarmbotOS.Celery.VariableTransformerTest do
     expected = [fake_stuff]
     assert actual == expected
   end
+
+  test "CS Resource" do
+    id = 999_999
+    sequence = FarmbotOS.Asset.new_sequence!(%{id: id})
+    params = %{args: %{resource_id: id, resource_type: "Sequence"}}
+    [result] = VariableTransformer.run!(params)
+    assert result == sequence
+  end
+
+  test "CS Resource - not known" do
+    unknown = %{args: %{resource_id: 111, resource_type: "Foo"}}
+    [result] = VariableTransformer.run!(unknown)
+    assert result == unknown
+  end
+
+  test "CS Resource - not found" do
+    not_found = %{args: %{resource_id: 111, resource_type: "Sequence"}}
+    [result] = VariableTransformer.run!(not_found)
+    refute result
+  end
 end