Skip to content

As a dashboard user, I can define an action to enable / disable a flag for a given segment in a release pipeline stage #5272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewelwell opened this issue Mar 31, 2025 · 0 comments

Comments

@matthewelwell
Copy link
Contributor

matthewelwell commented Mar 31, 2025

TODO

Considerations:

  • What happens if a flag already has existing segment overrides?
  • What happens if a flag already has an override for the segment defined by the given stage?

Answer to the above:

This action should just ignore any existing segment overrides. The release pipeline should add any new segments, and leave existing ones, assuming there isn't any conflict. If there is already a segment override for the segment defined in the given release pipeline stage, the release pipeline should clobber the existing override.

Discussion 04/11/2025

We talked about the locking of a flag with regards to segment overrides. The current plan is to lock the flag to any segment override and environment level modifications, but we could perhaps in the future only lock segment override modifications for the segments that exist in the release pipeline. This would benefit customers that want to slowly migrate over to release pipelines so they may only want to use the pipelines for certain segments, and not others.

We should also prevent the segment from being deleted when it used as part of a release pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant