Skip to content

As a dashboard user, when viewing a flag in a given environment, I can add it to a release pipeline #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewelwell opened this issue Mar 31, 2025 · 5 comments

Comments

@matthewelwell
Copy link
Contributor

matthewelwell commented Mar 31, 2025

TODO

Considerations:

  • Adding a flag to a release pipeline should lock the flag for editing. Users should have to remove it from the release pipeline before making manual changes to the flag.
  • Should we only allow flags to be added to release pipelines for which the first stage is for the current environment the user is viewing the flag in?
    • Alternatives:
      • Have a view of a feature at the project level
      • Just allow them to add flags to any release pipeline, regardless of the environment (but perhaps show a warning when adding to a release pipeline for which the first stage is not in the current environment)
        • Agreed that this is the best option.
@gagantrivedi
Copy link
Member

gagantrivedi commented Apr 2, 2025

Adding a flag to a release pipeline should lock the flag for editing

In all environments?

@matthewelwell
Copy link
Contributor Author

Adding a flag to a release pipeline should lock the flag for editing

In all environments?

Good question. This depends on if we think we can allow pipelines to work across multiple environments or not?

@gagantrivedi
Copy link
Member

This depends on if we think we can allow pipelines to work across multiple environments or not?

The Figma assumes that we do... it will be very limited otherwise?

@matthewelwell
Copy link
Contributor Author

matthewelwell commented Apr 2, 2025

Yes, but it was one of the things we though about restricting in the first version. I'm happy to include it in the first version if we think that we can technically achieve it. In which case, it should lock it in all environments, yes.

@matthewelwell
Copy link
Contributor Author

As discussed, since we're allowing release pipelines to span multiple environments, we should lock the flag in all environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants