Merge pull request #504 from FrameworkComputer/hx20.charger_lpm

fix cannot charge in G3

Author: kiram9

board/hx20/board.c

@@ -399,6 +399,9 @@ DECLARE_HOOK(HOOK_INIT, vci_init, HOOK_PRIO_FIRST);
 static void board_power_off_deferred(void)
 {
 	int i;
+	/* Turn off BGATE and NGATE for power saving */
+	charger_psys_enable(0);
+	charge_gate_onoff(0);
 
 	/* Disable interrupts */
 	interrupt_disable();
@@ -535,7 +538,7 @@ void charge_gate_onoff(uint8_t enable)
 }
 
 
-void charge_psys_onoff(uint8_t enable)
+void charger_psys_enable(uint8_t enable)
 {
 	int control1 = 0x0000;
 	int control4 = 0x0000;
@@ -576,44 +579,6 @@ void charge_psys_onoff(uint8_t enable)
 	}
 }
 
-
-/*
- * Charger Low Power Mode Process
- * modern standby should not turn off Bfet and Nfet
- * DC only at S5 need enable
- * AC+DC at S5 & Fully charge need enable
- * AC+DC at Modern standby & Fully charge need enable
- * AC only need disable
- */
-void charger_low_power_update(void)
-{
-	static int ac_state;
-	static int dc_state;
-	int batt_status;
-
-	ac_state = extpower_is_present();
-	dc_state = battery_is_present();
-	battery_status(&batt_status);
-
-	if (dc_state && !ac_state &&
-		chipset_in_state(CHIPSET_STATE_ANY_OFF)) {
-		charge_gate_onoff(0);
-		charge_psys_onoff(0);
-	} else if (ac_state && dc_state &&
-		batt_status & STATUS_FULLY_CHARGED) {
-		if (chipset_in_state(CHIPSET_STATE_ANY_OFF)) {
-			charge_gate_onoff(0);
-			charge_psys_onoff(0);
-		} else if (chipset_in_state(CHIPSET_STATE_STANDBY))
-			charge_psys_onoff(0);
-	} else if (ac_state && !dc_state) {
-		charge_gate_onoff(1);
-		charge_psys_onoff(1);
-	}
-}
-DECLARE_HOOK(HOOK_AC_CHANGE, charger_low_power_update, HOOK_PRIO_DEFAULT);
-DECLARE_HOOK(HOOK_BATTERY_SOC_CHANGE, charger_low_power_update, HOOK_PRIO_DEFAULT);
-
 /* Initialize board. */
 static void board_init(void)
 {
@@ -647,8 +612,7 @@ static void board_chipset_startup(void)
 	if (version > 6)
 		gpio_set_level(GPIO_EN_INVPWR, 1);
 
-	charge_gate_onoff(1);
-	charge_psys_onoff(1);
+	charger_psys_enable(1);
 }
 DECLARE_HOOK(HOOK_CHIPSET_STARTUP,
 		board_chipset_startup,
@@ -667,11 +631,7 @@ static void board_chipset_shutdown(void)
 	lpc_set_host_event_mask(LPC_HOST_EVENT_SCI, 0);
 #endif
 
-	/* avoid AC mode enable charger LPM when charging*/
-	if (!extpower_is_present() || (batt_status & STATUS_FULLY_CHARGED)) {
-		charge_gate_onoff(0);
-		charge_psys_onoff(0);
-	}
+	charger_psys_enable(0);
 }
 DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN,
 		board_chipset_shutdown,
@@ -684,7 +644,7 @@ static void board_chipset_resume(void)
 	/*gpio_set_level(GPIO_ENABLE_BACKLIGHT, 1);*/
 	gpio_set_level(GPIO_EC_MUTE_L, 1);
 	gpio_set_level(GPIO_CAM_EN, 1);
-	charge_psys_onoff(1);
+	charger_psys_enable(1);
 }
 DECLARE_HOOK(HOOK_CHIPSET_RESUME, board_chipset_resume,
 	     MOTION_SENSE_HOOK_PRIO-1);
@@ -698,7 +658,7 @@ static void board_chipset_suspend(void)
 		gpio_set_level(GPIO_EC_MUTE_L, 0);
 		gpio_set_level(GPIO_CAM_EN, 0);
 	}
-	charge_psys_onoff(0);
+	charger_psys_enable(0);
 }
 DECLARE_HOOK(HOOK_CHIPSET_SUSPEND,
 		board_chipset_suspend,
@@ -885,6 +845,9 @@ static void charger_chips_init(void)
 
 	val = ISL9241_CONTROL1_PROCHOT_REF_6800 | ISL9241_CONTROL1_SWITCH_FREQ;
 
+	/* make sure battery FET is enabled on EC on */
+	val &= ~ISL9241_CONTROL1_BGATE;
+
 	if (i2c_write16(I2C_PORT_CHARGER, ISL9241_ADDR_FLAGS,
 		ISL9241_REG_CONTROL1, val))
 		goto init_fail;

board/hx20/board.h

@@ -775,6 +775,8 @@ void board_prepare_for_deep_sleep(void);
 void board_resume_from_deep_sleep(void);
 #endif
 
+void charge_gate_onoff(uint8_t enable);
+void charger_psys_enable(uint8_t enable);
 #endif /* !__ASSEMBLER__ */
 
 #endif /* __CROS_EC_BOARD_H */