Skip to content

Commit cbacb3e

Browse files
scott-collyerChromeos LUCI
authored and
Chromeos LUCI
committed
tcpmv2: pe: Add mux_set call following successful DATA_RESET
This CL adds a call to set_usb_mux_with_current_data_role after performing a successful DATA_RESET. This is being added to satisfy 6.3.14 Data_Reset Message, item #3: If the Port was operating in [USB 3.2] or [USB4] reapply the port’s Rx Terminations (see [USB 3.2]). Without this call a mode entry attempt that is either not successful, or rejected by the port partner would leave the USB3.x SS lanes disconnected. This would also be the case following an Exit_Mode request from the AP when DATA_RESET is supported. BUG=b:260095516 BRANCH=none TEST=using drivers.usbc_usb4_mode integration test to verify that the mux ends up in the correct state following a DATA_RESET. Signed-off-by: Scott Collyer <scollyer@google.com> Change-Id: I3b6f9d00beb5fcc5a68c44887bde03d22b61d3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4040832 Tested-by: Scott Collyer <scollyer@chromium.org> Commit-Queue: Scott Collyer <scollyer@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
1 parent 4dee64a commit cbacb3e

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

common/usbc/usb_pe_drp_sm.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7686,8 +7686,7 @@ static void pe_ddr_perform_data_reset_run(int port)
76867686
* interpretations are mutually exclusive. Resolve that
76877687
* ambiguity and update this implementation.
76887688
*/
7689-
usb_mux_set(port, USB_PD_MUX_NONE, USB_SWITCH_DISCONNECT,
7690-
polarity_rm_dts(pd_get_polarity(port)));
7689+
set_usb_mux_with_current_data_role(port);
76917690
} else if (IS_ENABLED(CONFIG_USBC_VCONN) &&
76927691
PE_CHK_FLAG(port, PE_FLAGS_VCONN_SWAP_COMPLETE) &&
76937692
tc_is_vconn_src(port)) {

0 commit comments

Comments
 (0)