Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam Squashers have 4x energy efficiency than intended (?) #16040

Closed
3 tasks done
PlayfulPiano opened this issue Apr 22, 2024 · 6 comments
Closed
3 tasks done

Steam Squashers have 4x energy efficiency than intended (?) #16040

PlayfulPiano opened this issue Apr 22, 2024 · 6 comments

Comments

@PlayfulPiano
Copy link
Contributor

Your GTNH Discord Username

PlayfulPiano

Your Pack Version

2.5.1

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

Assume the Compressed Air Cell Recipe.
2EU/t recipe for 15s
Steam Squasher does 8x parallel, so 2EU/t -> 16EU/t
Steam Ratios are 2L:1EU, so this means 32L/t usage
Then include the 50% efficiency of Steam Machines, this would double again to 64L/t usage. Or 1280L/s.

LV Fluid Heaters generate 960L/1.5s of steam, i.e. 640L/s.
Therefore, you would need 2 LV Fluid Heaters to keep up with a single Steam Squasher.

The Reality

In game I set up 2 steam squashers in a wallshared setup with a single steam hatch, powered by a single LV fluid heater. Assuming the above ratios, this should mean I would be unable to keep uptake of even a single squasher. Instead, both squashers are able to run consistently with 0 fluid loss overtime from the single LV fluid heater. i.e., 4x more efficient than ratios would intend.
This probably skips both the 50% efficiency AND the 2:1 steam L : EU ratio, or is otherwise just weird.

Your Proposal

Considering that a steam squasher is supposed to be equivalent to an HV compressor in terms of parallel, or an MV compressor in terms of parallel & efficiency, this should probably either get its ratios fixed to their intended values, or alternatively give it a smaller discount (2x over 4x?) so the sudden spike in steam cost isn't as harsh to newer players. Or make fluid heaters worse idk

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@PlayfulPiano PlayfulPiano added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Apr 22, 2024
@chochem chochem added Mod: GT++ and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Apr 22, 2024
@PlayfulPiano
Copy link
Contributor Author

I will say though that giving steam multis some discount bonus would be cool, although I guess it would make more sense to do that with the grinder than the squasher (as you'd be using HV macerators for byproducts but the squasher would just be objectively better than any EU based compressor till like EV or LPF).

@PlayfulPiano
Copy link
Contributor Author

ok just tested the macerating of an iron ingot in an LV macerator, a steam grinder, and a HP macerator:
all three have 2.8s durations
HP macerator costs "about 8eu/t" on tooltip
both LV macerator and steam grinder costs 4eu/t on tooltip

image
also, as per the gtnh, there seems to be an outdated bonus discount documented here that doesn't seem to match the above functionality?

so maybe there was some past discount that isn't easily viewable now? or something weird across versions?

As per wiki history, the discount mentioned was posted back in 2022 when the page was first made, so idk

image

@Glease
Copy link
Contributor

Glease commented Apr 22, 2024

large steam multi does not have the steam:energy 2:1 ratio. it instead treats it as 1:1. It also doesn't have the 50% effi penalty of single block bronze machines. these 2 factors combined leads to the 0.25x steam consumption you have observed.

I can't say if this is intended, but this is indeed part of why steam multis are so good.

@Glease Glease removed the GPL label Apr 22, 2024
@chochem
Copy link
Member

chochem commented Apr 22, 2024

there is nothing in the code history suggesting any intentional discounts. but in the end we can just decide on one.

@chochem chochem added the GPL label Apr 22, 2024
@chochem
Copy link
Member

chochem commented Apr 22, 2024

found the issue.
gpl label was fully correct. turns out it was broken here GTNewHorizons/GTplusplus#697
we should probably go back to the old values. the wiki was indeed correct.
image

it was a bit hidden. the speedbonus was set to 0 but then the final formula has a magic number appearing, see picture.

@chochem
Copy link
Member

chochem commented Apr 24, 2024

fixed by GTNewHorizons/GTplusplus#875

@chochem chochem closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants