Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand ECDH test vectors #136

Open
2 tasks
marsella opened this issue Sep 5, 2024 · 0 comments
Open
2 tasks

Expand ECDH test vectors #136

marsella opened this issue Sep 5, 2024 · 0 comments
Labels
improvement Addresses fixes or changes to existing specs Suite-B

Comments

@marsella
Copy link
Contributor

marsella commented Sep 5, 2024

Right now we have the CAVP test vectors to demonstrate the correct behavior for ECDH with P-256. We can expand this in two ways. First, we don't have any negative test vectors (e.g. to show that things aren't trivially correct / even invalid keys are approved). It might be good to think about whether there's a principled way to do this or if we should just mash some of the valid vectors to get invalid ones. Second, we could instantiate ECDH for more curves. NIST SP 800-186 allows all the prime-field curves to be used for EC key agreement (section 3.1.2, Table 2), so we might instantiate all of those and pull in all the corresponding CAVP test vectors.

  • Add some negative test cases for each method in ecdh
  • Add additional P-curves (P-224, P-384, P521) and CAVP test vectors
This was referenced Sep 5, 2024
@marsella marsella added Suite-B improvement Addresses fixes or changes to existing specs labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Addresses fixes or changes to existing specs Suite-B
Projects
None yet
Development

No branches or pull requests

1 participant