Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and audit ML-DSA #173

Closed
4 tasks done
marsella opened this issue Nov 8, 2024 · 2 comments
Closed
4 tasks done

Document and audit ML-DSA #173

marsella opened this issue Nov 8, 2024 · 2 comments
Assignees
@marsella
Labels
CNSA 2.0 post-quantum related to post-quantum cryptography specs version-update Addresses a new version of an existing spec

Comments

@marsella
Copy link
Contributor

marsella commented Nov 8, 2024 •
edited
Loading

We currently have an implementation of the initial public draft of ML-DSA (as well as the Round 1 and Round 2 versions from the NIST PQ competition). We want to update this to match the final spec of FIPS-204.

  • Move draft versions to a separate directory (consider deleting)
  • Take a pass of the existing IPD version, documenting the existing functionality
  • Audit for changes that will be necessary to bring the implementation up to our gold standard
  • Write follow-up issues to address the identified changes
@marsella marsella added post-quantum related to post-quantum cryptography specs CNSA 2.0 version-update Addresses a new version of an existing spec labels Nov 8, 2024
@marsella marsella self-assigned this Nov 8, 2024
marsella added a commit that referenced this issue Nov 12, 2024
@marsella
mldsa: rearrange mldsa test cases, constants #173
fedc771 
- moves each used test case to the version with which it is used
- deletes unused test cases
- move constants to the round1/2 dirs where they are used
@marsella marsella mentioned this issue Nov 13, 2024
Merged
marsella added a commit that referenced this issue Nov 14, 2024
@marsella
mldsa: add copyright notices to older files #173
877b0ee
marsella added a commit that referenced this issue Nov 15, 2024
@marsella
mldsa: rearrange mldsa test cases, constants #173
e4a0a11 
- moves each used test case to the version with which it is used
- deletes unused test cases
- move constants to the round1/2 dirs where they are used
marsella added a commit that referenced this issue Nov 15, 2024
@marsella
mldsa: add copyright notices to older files #173
5c93984
marsella added a commit that referenced this issue Nov 15, 2024
@marsella
mldsa: rename directory #173
78b0a2a
@marsella
Copy link
Contributor Author

I wrote a bunch of ML-DSA issues. The ones that remain to write are:

  • NTT and NTT arithmetic. Debating on whether to spin out the NTT module first or not (Consolidate and spec-ify NTT implementations #163)
  • Implement the internal functions
    • note new domain separation in alg 6
    • Also add a KAT at this point.
  • ML-DSA external functions
  • HashML-DSA external functions and any rearchitecting needed.

marsella added a commit that referenced this issue Nov 18, 2024
@marsella
mldsa: add copyright notices to old versions #173
d497dfd
@marsella
Copy link
Contributor Author

marsella commented Dec 2, 2024

Added #191, #192 #198, and #199 to cover the concerns in the previous comment.

@marsella marsella closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marsella marsella

Labels
CNSA 2.0 post-quantum related to post-quantum cryptography specs version-update Addresses a new version of an existing spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marsella