Skip to content

Commit 5a1597f

Browse files
authored
Merge pull request #12 from GitHawkApp/readability
Improve API readability
2 parents d76de64 + 3b56414 commit 5a1597f

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

StyledText/StyledTextRenderer.swift

+6-6
Original file line numberDiff line numberDiff line change
@@ -78,14 +78,14 @@ public final class StyledTextRenderer {
7878
return size
7979
}
8080

81-
public func size(width: CGFloat) -> CGSize {
81+
public func size(in width: CGFloat = .greatestFiniteMagnitude) -> CGSize {
8282
os_unfair_lock_lock(&lock)
8383
defer { os_unfair_lock_unlock(&lock) }
8484
return _size(StyledTextRenderCacheKey(width: width, attributedText: storage, backgroundColor: backgroundColor))
8585
}
8686

87-
public func viewSize(width: CGFloat) -> CGSize {
88-
return size(width: width).resized(inset: inset)
87+
public func viewSize(in width: CGFloat = .greatestFiniteMagnitude) -> CGSize {
88+
return size(in: width).resized(inset: inset)
8989
}
9090

9191
private static let globalBitmapCache = LRUCache<StyledTextRenderCacheKey, CGImage>(
@@ -94,7 +94,7 @@ public final class StyledTextRenderer {
9494
clearOnWarning: true
9595
)
9696

97-
public func render(width: CGFloat) -> (image: CGImage?, size: CGSize) {
97+
public func render(for width: CGFloat) -> (image: CGImage?, size: CGSize) {
9898
os_unfair_lock_lock(&lock)
9999
defer { os_unfair_lock_unlock(&lock) }
100100

@@ -142,8 +142,8 @@ public final class StyledTextRenderer {
142142
width: CGFloat
143143
) -> StyledTextRenderer {
144144
switch option {
145-
case .size: let _ = size(width: width)
146-
case .bitmap: let _ = render(width: width)
145+
case .size: let _ = size(in: width)
146+
case .bitmap: let _ = render(for: width)
147147
}
148148
return self
149149
}

StyledText/StyledTextView.swift

+4-4
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,16 @@ open class StyledTextView: UIView {
163163

164164
// MARK: Public API
165165

166-
open func configure(renderer: StyledTextRenderer, width: CGFloat) {
166+
open func configure(with renderer: StyledTextRenderer, width: CGFloat) {
167167
self.renderer = renderer
168168
layer.contentsScale = renderer.scale
169-
reposition(width: width)
169+
reposition(for: width)
170170
accessibilityLabel = renderer.string.allText
171171
}
172172

173-
open func reposition(width: CGFloat) {
173+
open func reposition(for width: CGFloat) {
174174
guard let renderer = self.renderer else { return }
175-
let result = renderer.render(width: width)
175+
let result = renderer.render(for: width)
176176
layer.contents = result.image
177177
frame = CGRect(origin: CGPoint(x: renderer.inset.left, y: renderer.inset.top), size: result.size)
178178
}

StyledTextTests/StyledTextRendererSnapshotTests.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import Snap_swift
1313
extension UIView {
1414

1515
func mount(width: CGFloat, renderer: StyledTextRenderer) -> UIView {
16-
frame = CGRect(origin: .zero, size: renderer.size(width: width))
17-
layer.contents = renderer.render(width: width).image
16+
frame = CGRect(origin: .zero, size: renderer.size(in: width))
17+
layer.contents = renderer.render(for: width).image
1818
return self
1919
}
2020

0 commit comments

Comments
 (0)