Skip to content

Commit b44fb8f

Browse files
authored
Merge pull request #57 from HarkerRobo/page-titles
Improve member page titles
2 parents ea513c2 + 1f74513 commit b44fb8f

24 files changed

+42
-4394
lines changed

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,6 @@ The config file should be stored as `config.json`. You can copy from the example
120120
Harker Robotics' apps use [@harker-robo/prettier-config](npmjs.com/package/@harker-robo/prettier-config) for standardized code style. To format your code:
121121

122122
npm run format
123-
124-
* [Ignoring files](https://prettier.io/docs/en/ignore.html)
125-
* [Auto-formatting](https://prettier.io/docs/en/editors.html)
123+
124+
- [Ignoring files](https://prettier.io/docs/en/ignore.html)
125+
- [Auto-formatting](https://prettier.io/docs/en/editors.html)

package-lock.json

+10-4,360
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

views/new/pages/about.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>About - Harker Robotics</title>
4+
<title>About | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/new/pages/calendar.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>Calendar - Harker Robotics</title>
4+
<title>Calendar | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/new/pages/contact.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html>
33

44
<head>
5-
<title>Contact - Harker Robotics</title>
5+
<title>Contact | Harker Robotics</title>
66
<%- include(__base + 'views/new/partials/analytics.ejs') %>
77

88
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/new/pages/media.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>Media - Harker Robotics</title>
4+
<title>Media | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/new/pages/member.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>About - Harker Robotics</title>
4+
<title>About | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/new/pages/outreach.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>Outreach - Harker Robotics</title>
4+
<title>Outreach | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/new/pages/pastleadership.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>Past Leadership - Harker Robotics</title>
4+
<title>Past Leadership | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/new/pages/sponsor.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>Sponsorship - Harker Robotics</title>
4+
<title>Sponsorship | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/pages/blog.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<title>Blog - Harker Robotics</title>
4+
<title>Blog | Harker Robotics</title>
55
<%- include(__base + 'views/new/partials/analytics.ejs') %>
66

77
<%- include(__base + 'views/new/partials/favicon.ejs') %>

views/pages/member/calendar.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Calendar" }) %>
55
<link rel="stylesheet" type="text/css" href="/css/member.css" />
66

77
<meta name="apple-mobile-web-app-capable" content="yes">

views/pages/member/error.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Error" }) %>
55
<link rel="stylesheet" type="text/css" href="/css/error.css" />
66
</head>
77
<body>

views/pages/member/index.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Portal" }) %>
55
</head>
66
<body>
77

views/pages/member/login.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Login" }) %>
55
</head>
66
<body>
77

views/pages/member/parts/create.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Create Part" }) %>
55
<link rel="stylesheet" type="text/css" href="/css/parts.css" />
66
<link rel="stylesheet" type="text/css" href="/css/datepicker.css" />
77
</head>

views/pages/member/parts/edit.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Edit Part" }) %>
55
<link rel="stylesheet" type="text/css" href="/css/parts.css" />
66
<link rel="stylesheet" type="text/css" href="/css/datepicker.css" />
77
</head>

views/pages/member/purchase/create.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Create PR" }) %>
55
<link rel="stylesheet" type="text/css" href="/css/purchase.css?v=3" />
66
<style>
77
@media screen and (max-width: 800px) {

views/pages/member/purchase/edit.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs', {title: `Edit PR #${purchase.purchase_id} - ${purchase.vendor} | Harker Robotics 1072`}) %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: `Edit PR #${purchase.purchase_id} - ${purchase.vendor}` }) %>
55
<link rel="stylesheet" type="text/css" href="/css/purchase.css?v=3" />
66
</head>
77
<body>

views/pages/member/purchase/list.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "PR System" }) %>
55
</head>
66
<body>
77

views/pages/member/purchase/view.ejs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs', {title: `View PR #${purchase.purchase_id} - ${purchase.vendor} | Harker Robotics 1072`}) %>
4+
<%- include(__base + 'views/partials/head.ejs', {title: `View PR #${purchase.purchase_id} - ${purchase.vendor}`}) %>
55
<link rel="stylesheet" type="text/css" href="/css/purchase.css?v=3" />
66
<style media="print">
77
#approval-buttons {
@@ -309,7 +309,7 @@
309309
<% } %>
310310
311311
window.addEventListener("beforeprint", () => document.title = "OID<%= purchase.purchase_id %>" );
312-
window.addEventListener("afterprint", () => document.title = "View PR #<%= purchase.purchase_id %> - <%= purchase.vendor %> | Harker Robotics 1072" );
312+
window.addEventListener("afterprint", () => document.title = "View PR #<%= purchase.purchase_id %> - <%= purchase.vendor %>" );
313313
</script>
314314

315315

views/pages/member/resources.ejs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!DOCTYPE html>
22
<html>
33
<head>
4-
<%- include(__base + 'views/partials/head.ejs') %>
4+
<%- include(__base + 'views/partials/head.ejs', { title: "Resources" }) %>
55
<link rel="stylesheet" type="text/css" href="/css/member.css" />
66

77
<meta name="apple-mobile-web-app-capable" content="yes">

views/pages/member/shortener.ejs

+6-6
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
<!-- <script src="/js/index.js" defer></script> -->
66
<title> URL Shortener</title>
77
<meta charset="UTF-8">
8-
<meta name="viewport" content="width=device-width, initial-scale=1.0">
9-
<meta http-equiv="X-UA-Compatible" content="ie=edge">
8+
<meta name="viewport" content="width=device-width, initial-scale=1.0">
9+
<meta http-equiv="X-UA-Compatible" content="ie=edge">
1010

11-
<meta name="google" content="notranslate" />
11+
<meta name="google" content="notranslate" />
1212

13-
<link rel="shortcut icon" href="/favicon.ico">
14-
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
15-
<link href="https://fonts.googleapis.com/icon?family=Noto+Sans" rel="stylesheet">
13+
<link rel="shortcut icon" href="/favicon.ico">
14+
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
15+
<link href="https://fonts.googleapis.com/icon?family=Noto+Sans" rel="stylesheet">
1616
</head>
1717
<body>
1818
<div id="link-main">

views/partials/head.ejs

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
<title>
22
<% if (typeof title == 'string') { %>
3-
<%- title %>
4-
<% } else { %>
5-
Harker Robotics 1072
6-
<% } %>
3+
<%- title %> |
4+
<% } %> Harker Robotics
75
</title>
86

97
<meta name="viewport" content="width=device-width, initial-scale=1" />

0 commit comments

Comments
 (0)