[UI/UX] Remove 'Check for Updates on Startup' setting (#1250)

* [UI/UX] Remove 'Check for Updates on Startup' setting

* [UI/UX] Remove 'Check for HyperPlay Updates on Startup' translation entry

---------

Co-authored-by: Flavio F Lima <flavioislima@users.noreply.github.com>

Author: flavioislima

public/locales/en/translation.json

@@ -884,7 +884,6 @@
         "autoUpdateGames": "Automatically update games",
         "autovkd3d": "Auto Install/Update VKD3D on Prefix",
         "change-target-exe": "Select an alternative EXE to run",
-        "checkForUpdatesOnStartup": "Check for HyperPlay Updates on Startup",
         "crossover-version": "Crossover/Wine Version",
         "custom_themes_path": "Custom Themes Path",
         "customWineProton": "Custom Wine/Proton Paths",

src/backend/config.ts

@@ -295,7 +295,6 @@ class GlobalConfigV0 extends GlobalConfig {
       autoInstallDxvkNvapi: false,
       addSteamShortcuts: false,
       preferSystemLibs: false,
-      checkForUpdatesOnStartup: !isLinux,
       autoUpdateGames: true,
       customWinePaths: isWindows ? null : [],
       defaultInstallPath: installPath,

src/backend/updater/updater.ts

@@ -2,7 +2,7 @@ import { app, dialog, shell } from 'electron'
 import { autoUpdater } from 'electron-updater'
 import { t } from 'i18next'
 
-import { configStore, icon, isLinux } from '../constants'
+import { icon, isLinux } from '../constants'
 import { logError, logInfo, LogPrefix } from '../logger/logger'
 import { captureException } from '@sentry/electron'
 import { getFileSize } from '../utils'
@@ -12,11 +12,9 @@ import { getErrorMessage, removeCachedUpdatesFolder } from './utils'
 // to test auto update on windows locally make sure you added the option verifyUpdateCodeSignature: false
 // under build.win in electron-builder.yml and also change the app version to an old one there
 
-const appSettings = configStore.get_nodefault('settings')
-const shouldCheckForUpdates = appSettings?.checkForUpdatesOnStartup === true
 let newVersion: string
 
-autoUpdater.autoDownload = shouldCheckForUpdates && !isLinux
+autoUpdater.autoDownload = !isLinux
 autoUpdater.autoInstallOnAppQuit = true
 
 let isAppUpdating = false
@@ -29,7 +27,7 @@ const MAX_UPDATE_ATTEMPTS = 10
 const checkUpdateInterval = 3 * 1000 * 60 * 60
 
 setInterval(async () => {
-  if (shouldCheckForUpdates && !hasUpdated && !isAppUpdating) {
+  if (!hasUpdated && !isAppUpdating) {
     logInfo('Checking for client updates...', LogPrefix.AutoUpdater)
     await autoUpdater.checkForUpdates()
   }
@@ -44,14 +42,6 @@ autoUpdater.on('update-available', async (info) => {
     return
   }
 
-  if (!shouldCheckForUpdates) {
-    logInfo(
-      'New update available, but user has disabled auto updates',
-      LogPrefix.AutoUpdater
-    )
-
-    return
-  }
   newVersion = info.version
 
   trackEvent({

src/frontend/screens/Settings/components/CheckUpdatesOnStartup.tsx

@@ -4,7 +4,6 @@ export { default as AutoDXVKNVAPI } from './AutoDXVKNVAPI'
 export { default as AutoUpdateGames } from './AutoUpdateGames'
 export { default as AutoVKD3D } from './AutoVKD3D'
 export { default as BattlEyeRuntime } from './BattlEyeRuntime'
-export { default as CheckUpdatesOnStartup } from './CheckUpdatesOnStartup'
 export { default as CrossoverBottle } from './CrossoverBottle'
 export { default as CustomWineProton } from './CustomWineProton'
 export { default as DefaultInstallPath } from './DefaultInstallPath'

src/frontend/screens/Settings/components/index.ts

@@ -3,7 +3,6 @@ import { useTranslation } from 'react-i18next'
 import LanguageSelector from 'frontend/components/UI/LanguageSelector'
 import {
   AutoUpdateGames,
-  CheckUpdatesOnStartup,
   DefaultInstallPath,
   DefaultSteamPath,
   EgsSettings,
@@ -40,8 +39,6 @@ export default function GeneralSettings() {
 
       <AutoLaunchHyperPlay />
 
-      <CheckUpdatesOnStartup />
-
       <AutoUpdateGames />
 
       <TraySettings />