-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quest): add support for play streak progress sync #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. it's close
src/frontend/screens/Quests/components/QuestDetailsViewPlay/index.tsx
Outdated
Show resolved
Hide resolved
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! found a couple small things to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before signing my playstreak was 0/7 and after signing my playstreak was set to 7/7. I was then able to claim the "HP ERC20 Testing Quest". After claiming the streak returned to 0/7 and was no longer claimable.
I was able to set the playstreak to 7/7 with the "HP ERC721 Testing Quest", however, I was presented with an error when attempting to claim.
<--- Put the description here --->
steps to test: https://app.qase.io/case/HC-367
Use the following Checklist if you have changed something on the Backend or Frontend: