Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quest): add support for play streak progress sync #1100

Merged
merged 29 commits into from
Oct 22, 2024

Conversation

eliobricenov
Copy link
Contributor

@eliobricenov eliobricenov commented Oct 3, 2024

<--- Put the description here --->

steps to test: https://app.qase.io/case/HC-367


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@eliobricenov eliobricenov changed the title Feat/sync external packages feat(quest): add support for play streak progress sync Oct 7, 2024
@eliobricenov eliobricenov self-assigned this Oct 7, 2024
@eliobricenov eliobricenov added the PR: Ready-For-Review PR is ready to be reviewed by peers label Oct 8, 2024
@eliobricenov eliobricenov marked this pull request as ready for review October 8, 2024 16:07
Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. it's close

Copy link

github-actions bot commented Oct 17, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@BrettCleary BrettCleary self-requested a review October 18, 2024 21:53
@eliobricenov
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@eliobricenov
Copy link
Contributor Author

recheck

Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! found a couple small things to address

Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. nice!

@eliobricenov eliobricenov added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Oct 21, 2024
Copy link
Contributor

@flavioislima flavioislima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before signing my playstreak was 0/7 and after signing my playstreak was set to 7/7. I was then able to claim the "HP ERC20 Testing Quest". After claiming the streak returned to 0/7 and was no longer claimable.

I was able to set the playstreak to 7/7 with the "HP ERC721 Testing Quest", however, I was presented with an error when attempting to claim.

image
image
image
image
image
image

@nyghtstalker
Copy link

Confirmed that I am now able to claim the ERC721 quests. Great job!

image

@eliobricenov eliobricenov merged commit 949a98e into main Oct 22, 2024
11 checks passed
@eliobricenov eliobricenov deleted the feat/sync-external-packages branch October 22, 2024 00:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@eliobricenov eliobricenov restored the feat/sync-external-packages branch October 31, 2024 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants