Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Improvements to Update modal on the Store #1108

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Oct 9, 2024

Since we got some feedback from users and devs that are not aware of the auto update and thinks that they always need to download the update manually.

It adds 2 new IPC calls that will be used from the store to check the current update status that can be updating, updated or idle (fallback).
Depending on the state we show a different message and action on the store.
If updating, it is possible to close the modal.
If has updated, a button to restart the client is shown.
If idle, we go back to the current behavior of showing the URL to download.

Also, re-enabled the autoInstallOnAppQuit option. I think was false by mistake.

Store changes: https://github.com/HyperPlay-Gaming/hyperplay-store/pull/223

How to test

  • Download and install the Windows build here from this PR.
  • Open HyperPlay and the Update Modal on the Store show should the Updating message.
  • On the HyperPlay logs screen you can see the download progress messages to confirm the app is being downloaded.
  • When asked if you want to restart to conclude the Update, select NO.
  • On the Store now the Update Modal should tell the update was completed and show a button to restart the client and apply the update.
  • If the client is not updating in the background (test on mac and linux that doesn't have auto update), it should show the current modal we have now.
  • Limitations: Messages are not updated automatically on the Store, only when navigating back and forth there.

Screenshots

image
image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima self-assigned this Oct 10, 2024
@flavioislima flavioislima added the PR: Ready-For-Review PR is ready to be reviewed by peers label Oct 10, 2024
@flavioislima flavioislima changed the title [UX] Check if app is updating before showing Update warning on Store [UX] Improvements to Update modal on the Store Oct 10, 2024
Copy link
Contributor

@jiyuu-jin jiyuu-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flavioislima flavioislima added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Oct 15, 2024
Copy link

@nyghtstalker nyghtstalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that I was able to get the auto update to work successfully.

I want to make sure and document my findings so it can be improved on later.

  • I couldn't get the auto update to trigger until I unchecked and then rechecked "Check for HP Updates on Startup" option in Settings. After restarting it started the update process.

  • A Windows notification (instead of the HP modal included in this PR) appears BEHIND the windows instead of ON TOP of the Window to inform the user that the update has finished and asks the user to restart. I barely noticed it in the toolbar at the bottom! This is very easy to miss...

image
image

@flavioislima
Copy link
Contributor Author

Yeah, I wonder if updating electron-updater will fix some of the bugs on the electron side. I will continue to improve this flow on future PRs.

Copy link

github-actions bot commented Oct 16, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@flavioislima
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@flavioislima
Copy link
Contributor Author

recheck

@flavioislima
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@flavioislima
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@flavioislima flavioislima merged commit 9931d23 into main Oct 17, 2024
7 of 9 checks passed
@flavioislima flavioislima deleted the feat/check_upt_api branch October 17, 2024 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants