-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Improvements to Update modal on the Store #1108
Conversation
43677a2
to
90d0461
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that I was able to get the auto update to work successfully.
I want to make sure and document my findings so it can be improved on later.
-
I couldn't get the auto update to trigger until I unchecked and then rechecked "Check for HP Updates on Startup" option in Settings. After restarting it started the update process.
-
A Windows notification (instead of the HP modal included in this PR) appears BEHIND the windows instead of ON TOP of the Window to inform the user that the update has finished and asks the user to restart. I barely noticed it in the toolbar at the bottom! This is very easy to miss...
Yeah, I wonder if updating electron-updater will fix some of the bugs on the electron side. I will continue to improve this flow on future PRs. |
This reverts commit 90d0461.
…desktop-client into feat/check_upt_api
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA |
Since we got some feedback from users and devs that are not aware of the auto update and thinks that they always need to download the update manually.
It adds 2 new IPC calls that will be used from the store to check the current update status that can be
updating
,updated
oridle
(fallback).Depending on the state we show a different message and action on the store.
If updating, it is possible to close the modal.
If has updated, a button to restart the client is shown.
If idle, we go back to the current behavior of showing the URL to download.
Also, re-enabled the
autoInstallOnAppQuit
option. I think wasfalse
by mistake.Store changes: https://github.com/HyperPlay-Gaming/hyperplay-store/pull/223
How to test
Updating
message.Screenshots
Use the following Checklist if you have changed something on the Backend or Frontend: