Skip to content

Commit aacc715

Browse files
committed
Fixes
1 parent ef624c2 commit aacc715

File tree

2 files changed

+15
-9
lines changed

2 files changed

+15
-9
lines changed

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<modelVersion>4.0.0</modelVersion>
44
<groupId>com.github.adriens.imgflip</groupId>
55
<artifactId>imgflip4j</artifactId>
6-
<version>1.3</version>
6+
<version>1.4</version>
77
<packaging>jar</packaging>
88
<description>A Java SDK to interact with Imgflip API.</description>
99
<properties>

src/main/java/com/github/adriens/imgflip/sdk/imgflip/sdk/PublishedMemesCrawler.java

+14-8
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,15 @@ public static List<PublishedMeme> getPublishedMemes()
4747

4848
public static List<PublishedMeme> getPublishedMemes(int page)
4949
throws IOException {
50-
return getPublishedMemes(null, page);
50+
return getPublishedMemes("fun", page);
5151
}
5252

5353
public static List<PublishedMeme> getPublishedMemes(String stream, int page)
5454
throws IOException {
55+
String lStream;
56+
if(stream == null || stream.isEmpty()){
57+
lStream = "fun";
58+
}
5559
String imgFlipUrl = ImgFlipURLHelper.getPagePath(stream, page);
5660
return getPublishedMemes(imgFlipUrl);
5761
}
@@ -71,10 +75,10 @@ public static List<PublishedMeme> getPublishedMemes(String targetUrl)
7175
Iterator<DomElement> memeDivsIterator = divMemesList.iterator();
7276
int i = 1;
7377
DomElement lDivision;
74-
String imgPath;
78+
//String imgPath;
7579
String imgTitle;
7680
String imgTitleAlt;
77-
HtmlElement lHref;
81+
//HtmlElement lHref;
7882
String rawXml;
7983
String lMemeTitle;
8084
HtmlElement lTitleElement;
@@ -97,12 +101,12 @@ public static List<PublishedMeme> getPublishedMemes(String targetUrl)
97101
logger.info("Meme title : <" + lMemeTitle + ">");
98102
lMeme.setTitle(lMemeTitle);
99103

100-
lHref = lDivision.getFirstByXPath(".//div[@class='base-img-wrap-wrap']/div[@class='base-img-wrap']/a");
104+
//lHref = lDivision.getFirstByXPath(".//div[@class='base-img-wrap-wrap']/div[@class='base-img-wrap']/a");
101105
//lHref = lDivision.getFirstByXPath(".//h2[1]/a");
102106
//HtmlElement lHref = lDivision.getFirstByXPath("//h2[@class='base-unit-title']/a");
103107
//HtmlElement lHref = lDivision.getFirstByXPath("/html/body/div[2]/div[3]/div[6]/h2/a");
104108
//logger.info("href : <" + lHref + ">");
105-
imgPath = lHref.getAttribute("href");
109+
//imgPath = lHref.getAttribute("href");
106110
//imgTitleAlt = lHref.getAttribute("alt");
107111
//logger.info(lHref.asXml());
108112
//logger.info("Found href : <" + imgPath + ">");
@@ -219,11 +223,13 @@ public static String getNextPageUrl(String anyImgflipUrl) throws IOException {
219223
}
220224

221225
public static void main(String[] args) throws Exception {
222-
//List<PublishedMeme> memes = PublishedMemesCrawler.getPublishedMemes();
226+
List<PublishedMeme> memes = PublishedMemesCrawler.getPublishedMemes();
223227
//PublishedmemesCrawler.getNextPageUrl("https://imgflip.com/";//m/fun?sort=latest&after=53z8gv");
224-
List<PublishedMeme> memes = PublishedMemesCrawler.getPublishedMemes("fun", 1);
228+
//List<PublishedMeme> memes = PublishedMemesCrawler.getPublishedMemes("fun", 1);
229+
int i = 1;
225230
for (PublishedMeme aMeme : memes) {
226-
System.out.println(aMeme);
231+
System.out.println(i + ". " + aMeme);
232+
i++;
227233
}
228234
System.exit(0);
229235
}

0 commit comments

Comments
 (0)