Change to constexpr and use the appropriate type for DELAY_BETWEEN_ATTEMPTS

Since xTicksToWait is TickType_t (uint32) and SDL_Delay takes uint32 as well, we should avoid any chance of funny business due to differences in signedness.

Author: dariusarnold

sim/semphr.cpp

@@ -13,7 +13,7 @@ QueueHandle_t xSemaphoreCreateMutex() {
 BaseType_t xSemaphoreTake(SemaphoreHandle_t xSemaphore,
                           TickType_t xTicksToWait) {
   Queue_t *pxQueue = (Queue_t *)xSemaphore;
-  const int DELAY_BETWEEN_ATTEMPTS = 25;
+  constexpr TickType_t DELAY_BETWEEN_ATTEMPTS = 25;
   do {
     if (pxQueue->mutex.try_lock()) {
       std::lock_guard<std::mutex> lock(pxQueue->mutex, std::adopt_lock);