Skip to content

Commit 624429b

Browse files
authored
Merge pull request #830 from InfiniTimeOrg/fix-unresponsive-touchpanel
Fix unresponsive touch panel after update to 1.7
2 parents a57fda6 + 9671a84 commit 624429b

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.10)
2-
project(pinetime VERSION 1.7.0 LANGUAGES C CXX ASM)
2+
project(pinetime VERSION 1.7.1 LANGUAGES C CXX ASM)
33

44
set(CMAKE_C_STANDARD 99)
55
set(CMAKE_CXX_STANDARD 14)

src/drivers/Cst816s.cpp

+5-11
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,11 @@ bool Cst816S::Init() {
3232
twiMaster.Read(twiAddress, 0xa7, &dummy, 1);
3333
vTaskDelay(5);
3434

35-
static constexpr uint8_t maxRetries = 3;
36-
bool isDeviceOk;
37-
uint8_t retries = 0;
38-
do {
39-
isDeviceOk = CheckDeviceIds();
40-
retries++;
41-
} while (!isDeviceOk && retries < maxRetries);
42-
43-
if (!isDeviceOk) {
44-
return false;
45-
}
35+
// TODO This function check that the device IDs from the controller are equal to the ones
36+
// we expect. However, it seems to return false positive (probably in case of communication issue).
37+
// Also, it seems that some users have pinetimes that works correctly but that report different device IDs
38+
// Until we know more about this, we'll just read the IDs but not take any action in case they are not 'valid'
39+
CheckDeviceIds();
4640

4741
/*
4842
[2] EnConLR - Continuous operation can slide around

0 commit comments

Comments
 (0)